Force tasks with no files as failed

[benoit74]

Fix #90

[codecov]

Codecov Report

Attention: Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.

Project coverage is 46.11%. Comparing base (6eaea92) to head (0941055).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
api/src/zimitfrontend/routes/hook.py	0.00%	5 Missing ⚠️
api/src/zimitfrontend/routes/utils.py	75.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   46.35%   46.11%   -0.25%     
==========================================
  Files          10       10              
  Lines         384      386       +2     
  Branches       43       44       +1     
==========================================
  Hits          178      178              
- Misses        205      206       +1     
- Partials        1        2       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rgaudin]

Haven't checked the template to find out what happens exactly but this with current line 133 is a mistake

return MailToSend(status=SUCCESS, target=target, subject=subject, body=body)

[benoit74]

I don't get why? Because status=SUCCESS? This status is the hook return status, and this should be SUCCESS (and we should rename it for clarity ^^)

[rgaudin]

Please do so in this PR. This function used to return only on failures and only reach this point when everything's fine. Now that we get to this point with a failed task, we need to be more careful. We don't want to have to look at the templates to find this out

[benoit74]

This function used to return only on failures and only reach this point when everything's fine.

Nope, this function already reached this point when task status was among "requested", "succeeded", "failed" or "canceled". See line

zimit-frontend/api/src/zimitfrontend/routes/utils.py

Line 109 in 6eaea92

if task.status not in ("requested", "succeeded", "failed", "canceled"):

But anyway, will fix this in this PR, better now than never