Bump golang, k8s #37
Merged
Bump golang, k8s #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-345
to
-380
| { | ||
| Name: "reconcile deletetion", | ||
| GVK: gvk, | ||
| ReconcilePeriod: 5 * time.Second, | ||
| Runner: &fake.Runner{ | ||
| JobEvents: []eventapi.JobEvent{ | ||
| eventapi.JobEvent{ | ||
| Event: eventapi.EventPlaybookOnStats, | ||
| Created: eventapi.EventTime{Time: eventTime}, | ||
| }, | ||
| }, | ||
| Finalizer: "testing.io/finalizer", | ||
| }, | ||
| Client: fakeclient.NewClientBuilder().WithObjects(&unstructured.Unstructured{ | ||
| Object: map[string]interface{}{ | ||
| "metadata": map[string]interface{}{ | ||
| "name": "reconcile", | ||
| "namespace": "default", | ||
| "annotations": map[string]interface{}{ | ||
| controller.ReconcilePeriodAnnotation: "3s", | ||
| }, | ||
| "deletionTimestamp": eventTime.Format(time.RFC3339), | ||
| }, | ||
| "apiVersion": "operator-sdk/v1beta1", | ||
| "kind": "Testing", | ||
| "spec": map[string]interface{}{}, | ||
| }, | ||
| }).Build(), | ||
| Result: reconcile.Result{}, | ||
| Request: reconcile.Request{ | ||
| NamespacedName: types.NamespacedName{ | ||
| Name: "reconcile", | ||
| Namespace: "default", | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Why is this test now unnecessary?
There was a problem hiding this comment.
I bet this is because of the behaviour of the fake client which has changed in controller-runtime and now requires a sub resource to be present explicitly, which makes this unnecessary as the next test does the same. Should have commented while making this change :/
Let me run it locally and see if my brain remembers!
grokspawn
reviewed
Oct 18, 2023
oceanc80
force-pushed
the
k8s-bump
branch
3 times, most recently
from
cd8f4e8 to
9d47b30
Compare
|
@oceanc80 Also realized that we need to bump this: ansible-operator-plugins/Makefile Line 12 in cbc2d46 |
oceanc80
force-pushed
the
k8s-bump
branch
2 times, most recently
from
2987e77 to
635d52a
Compare
|
oceanc80
force-pushed
the
k8s-bump
branch
2 times, most recently
from
51bf8c6 to
495781e
Compare
oceanc80
force-pushed
the
k8s-bump
branch
4 times, most recently
from
acbb5fd to
de27b35
Compare
joelanford
reviewed
Nov 15, 2023
joelanford
reviewed
Nov 15, 2023
joelanford
reviewed
Nov 15, 2023
oceanc80
force-pushed
the
k8s-bump
branch
2 times, most recently
from
290bc4a to
7af40e3
Compare
Signed-off-by: Catherine Chan-Tse <[email protected]>
Signed-off-by: everettraven <[email protected]>
Signed-off-by: everettraven <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Transfer ansible-operator-plugins changes from operator-framework/operator-sdk#6514 to this repository.
Motivation for the change:
Bump k8s, golang and golang.org/x/net version