Refactor solver and move to internal #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: perdasilva <[email protected]>
|
|
oceanc80
reviewed
Dec 22, 2022
| Installed: []deppy.Identifier{"a", "b", "y"}, | ||
| }, | ||
| { | ||
| Name: "foo two dependencies satisfied by one variable", |
There was a problem hiding this comment.
Maybe remove the test above in favor of this one?
|
New changes are detected. LGTM label has been removed. |
Signed-off-by: perdasilva <[email protected]>
Signed-off-by: perdasilva <[email protected]>
perdasilva
force-pushed
the
73_refactor_solver
branch
from
6197176 to
d6bd646
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the sat solver and makes it possible to hide it in the internal package
Closes #73