-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add properties.yaml to dependencies #227
Add properties.yaml to dependencies #227
Conversation
Fixes: operator-framework/operator-registry#912 I also fixed the comments about the version of **OPM** and **OLM** that is required for dependencies.yaml and properties.yaml and
content/en/docs/Concepts/olm-architecture/dependency-resolution/_index.md
Outdated
Show resolved
Hide resolved
Fix OPM version for dependencies.yaml.
content/en/docs/Concepts/olm-architecture/dependency-resolution/_index.md
Show resolved
Hide resolved
@joelanford @dinhxuanvu Have been closer to this domain than I have, so it might be worth getting sign off from them before we merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @anik120 |
/cc @perdasilva @joelanford it looks like this is ready to go imo and only needs an approval at this point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
@anik120 Can you approve this PR? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
- `dependencies.yaml` file | ||
- `properties.yaml` file (supported by `1.17.4+ versions of OPM) | ||
|
||
Each of these files can be included in the `metadata` directory of the operator bundle. For more information on bundles and the their format, see the [bundle docs](https://github.com/operator-framework/operator-registry/blob/master/docs/design/operator-bundle.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice at some point we have this doc on the olm website.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume once this is merged, it will show up here:
https://olm.operatorframework.io/docs/concepts/olm-architecture/dependency-resolution/
Isn't this the "OLM website"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe we have documentation around the OLM bundle format (e.g. registry+v1) on the official OLM documentation site, so we always reference the documentation that lives in the operator-registry repository as the source of truth. I think Camila was alluding to mirroring that operator-bundle.md documentation to the olm.operatorframework.io website, so we can have all documentation under one roof, vs. scattered throughout multiple repositories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably tie into this:
#187
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120, cdjohnson, dinhxuanvu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes: operator-framework/operator-registry#912
I also fixed the comments about the version of OPM and OLM that is required for dependencies.yaml and properties.yaml. This is based off of looking the commits for these PRs.