-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecation information to docs #323
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of nits that will switch you from passive to active voice and a reminder to close the YAML block. 👍 Otherwise, LGTM.
@theishshah finished review. Looking pretty close now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Ish Shah <[email protected]>
Signed-off-by: Ish Shah <[email protected]>
Signed-off-by: Ish Shah <[email protected]>
Signed-off-by: Ish Shah <[email protected]>
Co-authored-by: Bryce Palmer <[email protected]> Signed-off-by: Ish Shah <[email protected]>
Co-authored-by: Michael Peter <[email protected]> Signed-off-by: Ish Shah <[email protected]>
Signed-off-by: Ish Shah <[email protected]>
Co-authored-by: Michael Peter <[email protected]> Co-authored-by: Jordan Keister <[email protected]> Signed-off-by: Ish Shah <[email protected]>
Signed-off-by: Ish Shah <[email protected]>
2a6ab30
to
d0da240
Compare
Add docs for olm.deprecation feature #318