Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation information to docs #323

Merged
merged 9 commits into from
Feb 12, 2024
Merged

Add deprecation information to docs #323

merged 9 commits into from
Feb 12, 2024

Conversation

theishshah
Copy link
Member

Add docs for olm.deprecation feature #318

content/en/docs/Reference/file-based-catalogs.md Outdated Show resolved Hide resolved
content/en/docs/Reference/file-based-catalogs.md Outdated Show resolved Hide resolved
content/en/docs/Reference/file-based-catalogs.md Outdated Show resolved Hide resolved
content/en/docs/Reference/file-based-catalogs.md Outdated Show resolved Hide resolved
Copy link
Contributor

@michaelryanpeter michaelryanpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nits that will switch you from passive to active voice and a reminder to close the YAML block. 👍 Otherwise, LGTM.

content/en/docs/Reference/file-based-catalogs.md Outdated Show resolved Hide resolved
content/en/docs/Reference/file-based-catalogs.md Outdated Show resolved Hide resolved
content/en/docs/Reference/file-based-catalogs.md Outdated Show resolved Hide resolved
@grokspawn
Copy link
Contributor

@theishshah finished review. Looking pretty close now!

Copy link
Contributor

@grokspawn grokspawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ish Shah and others added 9 commits February 12, 2024 08:33
Signed-off-by: Ish Shah <[email protected]>
Signed-off-by: Ish Shah <[email protected]>
Signed-off-by: Ish Shah <[email protected]>
Signed-off-by: Ish Shah <[email protected]>
Co-authored-by: Bryce Palmer <[email protected]>
Signed-off-by: Ish Shah <[email protected]>
Co-authored-by: Michael Peter <[email protected]>
Signed-off-by: Ish Shah <[email protected]>
Co-authored-by: Michael Peter <[email protected]>
Co-authored-by: Jordan Keister <[email protected]>
Signed-off-by: Ish Shah <[email protected]>
@grokspawn grokspawn merged commit 214bf08 into master Feb 12, 2024
6 checks passed
@oceanc80 oceanc80 deleted the olmdeprecation branch February 19, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants