✨ Install default-catalogs.yaml from Catalogd release #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
trgeiger
force-pushed
the
default-catalogs
branch
from
8b2645b to
1436b10
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1079 +/- ##
=======================================
Coverage 72.74% 72.74%
=======================================
Files 33 33
Lines 1948 1948
=======================================
Hits 1417 1417
Misses 381 381
Partials 150 150
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@trgeiger - requires rebase, and one of the e2e's is failing |
trgeiger
force-pushed
the
default-catalogs
branch
2 times, most recently
from
5cdb107 to
cefc214
Compare
|
@tmshort e2e passes now, it was mad about the presence of operatorhub.io so I just edited the setup script to remove it for the test. Codecov is mad but everything else is passing |
trgeiger
changed the title
trgeiger
force-pushed
the
default-catalogs
branch
from
cefc214 to
69e605d
Compare
trgeiger
changed the title
tmshort
reviewed
Jul 26, 2024
trgeiger
force-pushed
the
default-catalogs
branch
2 times, most recently
from
ac03d4a to
f1bba24
Compare
tmshort
reviewed
Jul 26, 2024
trgeiger
force-pushed
the
default-catalogs
branch
from
f1bba24 to
dd8f41e
Compare
Note: setup.sh for extension-developer-e2e now removes the OperatorHub clustercatalog so it doesn't interfere with testing. Signed-off-by: Tayler Geiger <[email protected]>
trgeiger
force-pushed
the
default-catalogs
branch
from
dd8f41e to
8ac1fe3
Compare
trgeiger
commented
Jul 26, 2024
| @@ -38,5 +39,10 @@ kubectl_wait "cert-manager" "deployment/cert-manager-webhook" "60s" | |||
| kubectl apply -f "https://github.com/operator-framework/catalogd/releases/download/${catalogd_version}/catalogd.yaml" | |||
| kubectl_wait "olmv1-system" "deployment/catalogd-controller-manager" "60s" | |||
|
|
|||
| if [[ "${install_default_catalogs,,}" != "false" ]]; then | |||
There was a problem hiding this comment.
I thought this made more sense than checking for true since we want the default to be installing the catalogs.
perdasilva
pushed a commit
to LalatenduMohanty/operator-controller
that referenced
this pull request
Aug 13, 2024
Note: setup.sh for extension-developer-e2e now removes the OperatorHub clustercatalog so it doesn't interfere with testing. Signed-off-by: Tayler Geiger <[email protected]>
perdasilva
pushed a commit
to kevinrizza/operator-controller
that referenced
this pull request
Aug 13, 2024
Note: setup.sh for extension-developer-e2e now removes the OperatorHub clustercatalog so it doesn't interfere with testing. Signed-off-by: Tayler Geiger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #1026 by adding OperatorHub to the default installation script.
Installs default-catalogs.yaml from Catalogd release.
Reviewer Checklist