📖 Quickstart #1142
Merged
📖 Quickstart #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1142 +/- ##
==========================================
- Coverage 77.27% 77.12% -0.15%
==========================================
Files 35 36 +1
Lines 1945 2020 +75
==========================================
+ Hits 1503 1558 +55
- Misses 308 327 +19
- Partials 134 135 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
perdasilva
force-pushed
the
perdasilva/docs/quistart
branch
10 times, most recently
from
9a99c15 to
4d1e2c0
Compare
perdasilva
force-pushed
the
perdasilva/docs/quistart
branch
2 times, most recently
from
77c26b6 to
7d8ecf1
Compare
added 2 commits
August 30, 2024 14:37
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
perdasilva
force-pushed
the
perdasilva/docs/quistart
branch
from
7d8ecf1 to
1a5d6cd
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
please review it in gdocs here |
Signed-off-by: Per Goncalves da Silva <[email protected]>
perdasilva
force-pushed
the
perdasilva/docs/quistart
branch
from
1a5d6cd to
aaf25f8
Compare
|
Please review the quickstart docs here - this PR will be subsequently updated |
joelanford
reviewed
Sep 5, 2024
| source: | ||
| type: image | ||
| image: | ||
| ref: quay.io/operatorhubio/catalog:latest |
There was a problem hiding this comment.
We install this catalog now as part of the install.sh script. Should we call that out?
There was a problem hiding this comment.
I approved and put in the merge queue, we can iterate if we feel more changes are really necessary.
joelanford
approved these changes
Sep 5, 2024
Merged
via the queue into
operator-framework:main
with commit Sep 5, 2024
c53453b
17 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quickstart documentation: please review it in gdocs here
Closes #1123
Reviewer Checklist