-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ update name validation patterns to match Kubernetes as close as possible #1175
⚠️ update name validation patterns to match Kubernetes as close as possible #1175
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1175 +/- ##
===========================================
- Coverage 77.56% 56.13% -21.43%
===========================================
Files 36 36
Lines 1979 1979
===========================================
- Hits 1535 1111 -424
- Misses 309 781 +472
+ Partials 135 87 -48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the before or after changes from this PR align to the validations that happen in opm validate
? We need to make sure that package and channel names are fully specified and validated the exact same way in both places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell, the validation for the package name does match. There does not appear to be any validation on channel names in opm validate
.
IMO we should merge the validation changes here and then add the validation of the channel name to opm validate
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to check known catalogs against these proposed validations before we merge so that we have more information to make a decision. We may ultimately decide to implement these validations despite breaking existing content, but we should know before we act.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gist that verified this validation works for all channel names in all known catalogs (except for one in the redhat certified operators index that looks like an unintentional channel name): https://gist.github.com/everettraven/4691c8cc6181f28b129f46cceeb602b5
c0bf806
to
bfaf8cb
Compare
…sible Signed-off-by: everettraven <[email protected]>
c629ded
to
61417d9
Compare
Signed-off-by: everettraven <[email protected]>
f797d50
Description
Updates existing field comments and validations to adhere more closely to Kubernetes naming conventions
Resolves Update validations for fields referencing the name of something to follow Kubernetes #1149
Reviewer Checklist