-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖[Docs] How-to: Channel-Based Automatic Updates #1220
📖[Docs] How-to: Channel-Based Automatic Updates #1220
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1220 +/- ##
==========================================
- Coverage 77.55% 76.49% -1.07%
==========================================
Files 35 40 +5
Lines 1916 2340 +424
==========================================
+ Hits 1486 1790 +304
- Misses 296 393 +97
- Partials 134 157 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I recommend slight rewording
name: argocd-installer | ||
``` | ||
|
||
Note that the `version` version range can also be set to further restrict the set of possible versions to upgrade to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be made clearer. Perhaps something like,
Note that the `version` field also accepts a version range to further restrict the set of possible operator versions to upgrade to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you!!
I've updated it and tried to remove the preposition at the end? wdyt?
17e52f2
to
e928d0a
Compare
Signed-off-by: Per Goncalves da Silva <[email protected]>
e928d0a
to
2efe604
Compare
ac5c28b
Description
Closes #1129
Reviewer Checklist