Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not include channel name or priority in bundle sorting during resolution #420

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

joelanford
Copy link
Member

@joelanford joelanford commented Sep 20, 2023

Description

#413 fixed the bug described in #419

This PR updates tests to ensure there are no regressions.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@joelanford joelanford requested a review from a team as a code owner September 20, 2023 03:15
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (52a1e28) 84.42% compared to head (c45fb33) 84.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #420   +/-   ##
=======================================
  Coverage   84.42%   84.42%           
=======================================
  Files          23       23           
  Lines         777      777           
=======================================
  Hits          656      656           
  Misses         86       86           
  Partials       35       35           
Flag Coverage Δ
e2e 66.92% <ø> (ø)
unit 76.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelanford joelanford marked this pull request as draft September 20, 2023 03:55
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2023
@joelanford joelanford marked this pull request as ready for review September 21, 2023 12:44
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2023
… sorting during resolution

Signed-off-by: Joe Lanford <[email protected]>
Copy link
Contributor

@dtfranz dtfranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joelanford joelanford added this pull request to the merge queue Sep 21, 2023
Merged via the queue into operator-framework:main with commit 92aacef Sep 21, 2023
12 checks passed
@joelanford joelanford deleted the fix-bundle-sorting branch June 20, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants