Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support EnvFrom #3193

Merged
merged 5 commits into from
Mar 27, 2024
Merged

Support EnvFrom #3193

merged 5 commits into from
Mar 27, 2024

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Mar 27, 2024

Update to #1950, alternative to #3191

Description of the change:

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

horis233 and others added 5 commits March 26, 2024 12:35
@horis233 @kevinrizza
Bug: Enable SubscriptionConfig EnvFrom field
b7e6814 
Problem: EnvFrom is claimed supported in the document, but it isn't enabled from the code

Solution: Wire the EnvFrom specified in the SubscriptionConfig into
the deployments deployed when installing the operator.

Signed-off-by: Jiaming Hu <[email protected]>
@horis233 @kevinrizza
add config envFrom overlaps test case
8e74d7a 
Signed-off-by: Jiaming Hu <[email protected]>
@kevinrizza
Fix test changes for envfrom
094b95f 
Signed-off-by: kevinrizza <[email protected]>
@tmshort
Cleanup fromEnv code
b84732f 
Signed-off-by: Todd Short <[email protected]>
@tmshort
Use reflect to compare fromEnv
a551799 
Signed-off-by: Todd Short <[email protected]>
@openshift-ci openshift-ci bot requested review from benluddy and kevinrizza March 27, 2024 14:48
@kevinrizza kevinrizza added this pull request to the merge queue Mar 27, 2024
@kevinrizza kevinrizza mentioned this pull request Mar 27, 2024
Closed
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 27, 2024
@kevinrizza kevinrizza added this pull request to the merge queue Mar 27, 2024
Merged via the queue into operator-framework:master with commit d9e3836 Mar 27, 2024
14 checks passed
@tmshort tmshort deleted the envfrom branch April 2, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinrizza kevinrizza kevinrizza approved these changes

@benluddy benluddy Awaiting requested review from benluddy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmshort @kevinrizza @horis233