[WIP] cache-fixes #3464
Open
[WIP] cache-fixes #3464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
perdasilva
force-pushed
the
perdasilva/fix-cache
branch
from
d1795f1 to
9036c7b
Compare
Signed-off-by: Per Goncalves da Silva <[email protected]>
perdasilva
force-pushed
the
perdasilva/fix-cache
branch
from
9036c7b to
61a0e72
Compare
Signed-off-by: Per Goncalves da Silva <[email protected]>
perdasilva
force-pushed
the
perdasilva/fix-cache
branch
from
ae0b265 to
39e8897
Compare
| @@ -197,6 +199,17 @@ func (o *operator) Run(ctx context.Context) { | |||
| }) | |||
| } | |||
|
|
|||
| func (o *operator) ResyncInformers() error { | |||
There was a problem hiding this comment.
No client using LIST + WATCH should ever have to do this, FWIW.
There was a problem hiding this comment.
Right, watch events are at least once right?
This mishmash of cached and live requests is biting us in the butt....
There was a problem hiding this comment.
In case you're curious: the issue is we have a situation in which the namespaces gets nuked and immediately recreated with the subscription, and we're ending up with unsat...
|
Using a |
Signed-off-by: Per Goncalves da Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds another reason why a Pod could be detected as "dead", namely when it was evicted by the kubelet. This can happen when there is resource pressure on the Node. Then the reason will be "TerminationByKubelet".
This addresses the issue described in
https://issues.redhat.com/browse/OCPBUGS-45490
Description of the change:
Motivation for the change:
Architectural changes:
Testing remarks:
Reviewer Checklist
/doc[FLAKE]are truly flaky and have an issue