Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ansible operator conditions #6582

Conversation

OchiengEd
Copy link
Contributor

Description of the change:

Given it is possible for a custom resource to be in error / failed state while a new reconcile process is ongoing, it is unnecessary to mark the status of previous Failure conditions to False while the reconcile loop is still running.

The failure condition will be removed when the custom resource is successfully deployed as it works today.

Motivation for the change:

The failure conditions have timestamps and are accurate as at the time of reporting. Therefore, it would be unnecessary and misleading to set the failure condition status to False before the custom resource is successfully deployed.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

Closes operator-framework/ansible-operator-plugins#18

Signed-off-by: Edmund Ochieng <[email protected]>
Don't reset previous failure condition until reconcile completes and
custom resource is successfully deployed.

Signed-off-by: Edmund Ochieng <[email protected]>
Signed-off-by: Edmund Ochieng <[email protected]>
@OchiengEd OchiengEd temporarily deployed to deploy September 26, 2023 14:18 — with GitHub Actions Inactive
@OchiengEd OchiengEd temporarily deployed to deploy September 26, 2023 14:18 — with GitHub Actions Inactive
@OchiengEd OchiengEd temporarily deployed to deploy September 26, 2023 14:18 — with GitHub Actions Inactive
@OchiengEd OchiengEd temporarily deployed to deploy September 26, 2023 14:18 — with GitHub Actions Inactive
@OchiengEd OchiengEd temporarily deployed to deploy September 26, 2023 14:18 — with GitHub Actions Inactive
@OchiengEd OchiengEd temporarily deployed to deploy September 26, 2023 14:19 — with GitHub Actions Inactive
@everettraven
Copy link
Contributor

@OchiengEd How do you feel about moving this PR to the new repository for the ansible operator logic?: https://github.com/operator-framework/ansible-operator-plugins

My thinking here is that since we are actively working to remove the ansible logic from this repository and import the new plugin library (I'm working on this in #6583) it would prevent duplication of work to transplant this to the new repo.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 28, 2023
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@OchiengEd
Copy link
Contributor Author

@everettraven Sure, we can move the PR. Don't have an opinion per se where the merge is done.

I can create a new PR in the new repo. Leaving this here until I do so

@OchiengEd OchiengEd changed the title Update ansible operator conditions [Do Not Merge] Update ansible operator conditions Sep 29, 2023
@OchiengEd
Copy link
Contributor Author

Issue has been moved to the ansible-operator-plugins repo. See operator-framework/ansible-operator-plugins#14

@OchiengEd OchiengEd closed this Sep 29, 2023
@OchiengEd OchiengEd changed the title [Do Not Merge] Update ansible operator conditions Update ansible operator conditions Sep 29, 2023
@OchiengEd OchiengEd deleted the update_ansible_operator_conditions branch September 29, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ansible-operator] Status false when type/reason = Successful
3 participants