Skip to content
eslint

Recurring meetings #7752

Sign in to view logs

Recurring meetings

Recurring meetings #7752

Triggered via pull request November 28, 2024 18:58
@oliverguentheroliverguenther
synchronize #15620
feature/recurring-meetings
Status Success
Total duration 3m 51s
Artifacts –

eslint-core.yml

on: pull_request
eslint
3m 43s
eslint
Fit to window
Zoom out
Zoom in

Annotations

1 warning and 12 notices
[rubocop] modules/meeting/app/forms/recurring_meeting/specific_date.rb#L43-L45 <Lint/MissingSuper>: modules/meeting/app/forms/recurring_meeting/specific_date.rb#L43
Call `super` to initialize state of the parent class.
[rubocop] modules/meeting/app/components/meetings/combined_filter_component.rb#L36 <Style/KeywordParametersOrder>: modules/meeting/app/components/meetings/combined_filter_component.rb#L36
Place optional keyword parameters at the end of the parameters list.
[rubocop] modules/meeting/app/components/meetings/index_sub_header_component.rb#L37 <Style/KeywordParametersOrder>: modules/meeting/app/components/meetings/index_sub_header_component.rb#L37
Place optional keyword parameters at the end of the parameters list.
[rubocop] modules/meeting/app/components/recurring_meetings/row_component.rb#L37 <Rails/Delegate>: modules/meeting/app/components/recurring_meetings/row_component.rb#L37
Use `delegate` to define delegations.
[rubocop] modules/meeting/app/components/recurring_meetings/row_component.rb#L104 <Layout/SpaceInsideHashLiteralBraces>: modules/meeting/app/components/recurring_meetings/row_component.rb#L104
Space inside } missing.
[rubocop] modules/meeting/app/components/recurring_meetings/show_page_header_component.rb#L68 <Style/StringConcatenation>: modules/meeting/app/components/recurring_meetings/show_page_header_component.rb#L68
Prefer string interpolation to string concatenation.
[rubocop] modules/meeting/app/components/recurring_meetings/show_page_sub_header_component.rb#L37 <Style/KeywordParametersOrder>: modules/meeting/app/components/recurring_meetings/show_page_sub_header_component.rb#L37
Place optional keyword parameters at the end of the parameters list.
[rubocop] modules/meeting/app/controllers/meetings_controller.rb#L72-L87 <Metrics/AbcSize>: modules/meeting/app/controllers/meetings_controller.rb#L72
Assignment Branch Condition size for show is too high. [<2, 16, 7> 17.58/17]
[rubocop] modules/meeting/app/controllers/meetings_controller.rb#L400-L419 <Metrics/AbcSize>: modules/meeting/app/controllers/meetings_controller.rb#L400
Assignment Branch Condition size for convert_params is too high. [<6, 16, 5> 17.8/17]
[rubocop] modules/meeting/app/forms/recurring_meeting/frequency.rb#L39 <Style/HashEachMethods>: modules/meeting/app/forms/recurring_meeting/frequency.rb#L39
Use `each_key` instead of `keys.each`.
[rubocop] modules/meeting/app/forms/recurring_meeting/interval.rb#L35 <Style/TrailingCommaInArguments>: modules/meeting/app/forms/recurring_meeting/interval.rb#L35
Avoid comma after the last parameter of a method call.
[rubocop] modules/meeting/spec/requests/recurring_meetings_spec.rb#L1 <Style/StringLiterals>: modules/meeting/spec/requests/recurring_meetings_spec.rb#L1
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
[rubocop] modules/meeting/spec/requests/recurring_meetings_spec.rb#L3 <RSpecRails/InferredSpecType>: modules/meeting/spec/requests/recurring_meetings_spec.rb#L3
Remove redundant spec type.