[chore] bump backend node engine (#14034)

* [chore] bump backend node engine - bump to v20, latest LTS * [chore] replaced node versions in docs
opf · Nov 2, 2023 · 029c059 · 029c059
1 parent fc6f39f
commit 029c059
Show file tree

Hide file tree

Showing 8 changed files with 17 additions and 13 deletions.
diff --git a/docker/ci/Dockerfile b/docker/ci/Dockerfile
@@ -2,7 +2,7 @@
 ARG RUBY_VERSION
 FROM ruby:${RUBY_VERSION}-bullseye
 
-ENV NODE_VERSION="16.17.0"
+ENV NODE_VERSION="20.9.0"
 ENV BUNDLER_VERSION="2.4.21"
 ENV DEBIAN_FRONTEND=noninteractive
 ENV BUNDLE_WITHOUT="development:production:docker"

diff --git a/docker/dev/backend/Dockerfile b/docker/dev/backend/Dockerfile
@@ -6,6 +6,7 @@ ARG DEV_GID=1001
 
 ENV USER=dev
 ENV RAILS_ENV=development
+ENV NODE_MAJOR=20
 
 ENV BUNDLER_VERSION "2.4.7"
 
@@ -27,7 +28,10 @@ RUN apt-get update -qq && \
 
 # Setup node source and install nodejs. Needed for running certain scripts in backend container,
 # as the `./scripts/api/validate_spec`.
-RUN curl -fsSL https://deb.nodesource.com/setup_14.x | bash -
+RUN mkdir -p /etc/apt/keyrings
+RUN curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg
+RUN echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_$NODE_MAJOR.x nodistro main" | tee /etc/apt/sources.list.d/nodesource.list
+RUN apt-get update
 RUN apt-get install -y nodejs
 
 # Install watchexec for continuous test execution.

diff --git a/docker/dev/frontend/Dockerfile b/docker/dev/frontend/Dockerfile
@@ -1,4 +1,4 @@
-FROM node:16.15
+FROM node:20.9
 MAINTAINER [email protected]
 
 ARG DEV_UID=1000

diff --git a/docker/prod/Dockerfile b/docker/prod/Dockerfile
@@ -1,5 +1,5 @@
 ARG RUBY_VERSION="3.2.2"
-ARG NODE_VERSION="16.17.0"
+ARG NODE_VERSION="20.9.0"
 ARG BUNDLER_VERSION="2.4.7"
 ARG DEBIAN_FRONTEND=noninteractive
 

diff --git a/docker/pullpreview-storybook/Dockerfile b/docker/pullpreview-storybook/Dockerfile
@@ -1,4 +1,4 @@
-FROM node:16.17 as build
+FROM node:20.9 as build
 
 COPY . /build
 WORKDIR /build/frontend

diff --git a/docs/development/development-environment-osx/README.md b/docs/development/development-environment-osx/README.md
@@ -104,11 +104,11 @@ $ nodenv init
 
 You can find the latest LTS version here: [nodejs.org/en/download](https://nodejs.org/en/download/)
 
-At the time of writing this is v16.17.0. Install and activate it with:
+At the time of writing this is v20.9.0. Install and activate it with:
 
 ```shell
-nodenv install 16.17.0
-nodenv global 16.17.0
+nodenv install 20.9.0
+nodenv global 20.9.0
 ```
 
 ### Update NPM to the latest version
@@ -129,10 +129,10 @@ $ bundler --version
 Bundler version 2.4.7
 
 node --version
-v16.17.0
+v20.9.0
 
 npm --version
-8.12.1
+10.1.0
 ```
 
 # Install OpenProject

diff --git a/docs/installation-and-operations/installation/manual/README.md b/docs/installation-and-operations/installation/manual/README.md
@@ -144,7 +144,7 @@ time to finish.
 To check our Node installation we run `node --version`. It should output something very similar to:
 
 ```
-v16.17.0
+v20.9.0
 ```
 
 ## Installation of OpenProject

diff --git a/package.json b/package.json
@@ -10,8 +10,8 @@
   },
   "private": true,
   "engines": {
-    "node": "~16.17.0",
-    "npm": "~8.12.1"
+    "node": "^20.9.0",
+    "npm": "^10.1.0"
   },
   "devDependencies": {
     "@redocly/openapi-cli": "^1.0.0-beta.80",
-Original file line number
+Diff line change
@@ Expand Up / @@ -144,7 +144,7 @@ time to finish. @@
     To check our Node installation we run `node --version`. It should output something very similar to:
     ```
-    v16.17.0
+    v20.9.0
     ```
     ## Installation of OpenProject
@@ Expand Down @@