Merge pull request #17495 from opf/remove-closed-flash-container

Remove closed banner container
opf · Dec 18, 2024 · 07f560a · 07f560a
2 parents a8fc3ad + 1316b43
commit 07f560a
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/app/components/op_primer/flash_component.erb → ...onents/op_primer/flash_component.html.erb b/app/components/op_primer/flash_component.erb → ...onents/op_primer/flash_component.html.erb
diff --git a/app/components/op_primer/flash_component.rb b/app/components/op_primer/flash_component.rb
@@ -38,6 +38,8 @@ def initialize(**system_arguments)
       system_arguments[:test_selector] ||= "op-primer-flash-message"
       system_arguments[:dismiss_scheme] ||= :remove
       system_arguments[:dismiss_label] ||= I18n.t(:button_close)
+      system_arguments[:data] ||= {}
+      system_arguments[:data]["flash-target"] = "flash"
 
       @autohide = system_arguments[:scheme] == :success && system_arguments[:dismiss_scheme] != :none
 

diff --git a/frontend/src/stimulus/controllers/flash.controller.ts b/frontend/src/stimulus/controllers/flash.controller.ts
@@ -11,9 +11,10 @@ export default class FlashController extends ApplicationController {
 
   static targets = [
     'item',
+    'flash', // only to detect removal
   ];
 
-  declare readonly itemTargets:HTMLElement;
+  declare readonly itemTargets:HTMLElement[];
 
   reloadPage() {
     window.location.reload();
@@ -25,4 +26,12 @@ export default class FlashController extends ApplicationController {
       setTimeout(() => element.remove(), SUCCESS_AUTOHIDE_TIMEOUT);
     }
   }
+
+  flashTargetDisconnected() {
+    this.itemTargets.forEach((target:HTMLElement) => {
+      if (target.innerHTML === '') {
+        target.remove();
+      }
+    });
+  }
 }