Fix failure message

opf · Sep 17, 2024 · 1997173 · 1997173
1 parent 885b7b0
commit 1997173
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/app/controllers/omni_auth_login_controller.rb b/app/controllers/omni_auth_login_controller.rb
@@ -56,7 +56,7 @@ def callback
 
   def failure
     log_omniauth_failure
-    show_error I18n.t(:error_external_authentication_failed, message: omniauth_error)
+    show_error I18n.t(:error_external_authentication_failed_message, message: omniauth_error)
   end
 
   private

diff --git a/config/locales/en.yml b/config/locales/en.yml
@@ -1745,7 +1745,7 @@ en:
     Can't rename "%{old_name}" to "%{new_name}" due to a conflict in the resulting menu item
     with the existing menu item "%{existing_caption}" (%{existing_identifier}).
 
-  error_external_authentication_failed: "An error occurred during external authentication: %{message}"
+  error_external_authentication_failed_message: "An error occurred during external authentication: %{message}"
   error_attribute_not_highlightable: "Attribute(s) not highlightable: %{attributes}"
 
   events:

diff --git a/spec/features/auth/omniauth_spec.rb b/spec/features/auth/omniauth_spec.rb
@@ -248,7 +248,7 @@ def translation_substring(translation)
           OmniAuth::FailureEndpoint.new(env).redirect_to_failure
         end
         visit login_path
-        expect(page).to have_content(I18n.t(:error_external_authentication_failed))
+        expect(page).to have_content(I18n.t(:error_external_authentication_failed_message, message: "Unknown error"))
 
         if defined? instructions
           expect(page).to have_content instructions