Revert "Add reminder note as an embedded notification detail"

This reverts commit a13494c.

config/locales/en.yml

@@ -1510,7 +1510,6 @@ en:
     login: "Username"
     mail: "Email"
     name: "Name"
-    note: "Note"
     password: "Password"
     priority: "Priority"
     project: "Project"

lib/api/v3/notifications/notification_representer.rb

@@ -104,7 +104,7 @@ def _type
           "Notification"
         end
 
-        self.to_eager_load = %i[actor journal reminder]
+        self.to_eager_load = %i[actor journal]
       end
     end
   end

lib/api/v3/values/schemas/value_schema_factory.rb

@@ -29,7 +29,7 @@
 module API::V3::Values::Schemas
   module ValueSchemaFactory
     extend ::API::V3::Utilities::PathHelper
-    SUPPORTED = %w(start_date due_date date note).freeze
+    SUPPORTED = %w(start_date due_date date).freeze
 
     module_function
 
@@ -64,13 +64,10 @@ def i18n_for(property)
       I18n.t("attributes.#{property}")
     end
 
-    def type_for(property)
-      case property
-      when "start_date", "due_date", "date"
-        "Date"
-      when "note"
-        "String"
-      end
+    def type_for(_property)
+      # This is but a stub. Currently, only 'start_date' and 'due_date'
+      # need to be supported so this simple approach works.
+      "Date"
     end
   end
 end

spec/lib/api/v3/notifications/notification_representer_rendering_spec.rb

@@ -267,60 +267,5 @@
                 .at_path("_embedded/details")
       end
     end
-
-    shared_examples_for "embeds a Values::Property for reminder note" do
-      it "embeds a Values::Property" do
-        expect(generated)
-          .to be_json_eql("Values::Property".to_json)
-                .at_path("_embedded/details/0/_type")
-      end
-
-      it "has a note value for the `property` property" do
-        expect(generated)
-          .to be_json_eql("note".to_json)
-                .at_path("_embedded/details/0/property")
-      end
-
-      it "has a reminder`s note for the value" do
-        expect(generated)
-          .to be_json_eql(notification.reminder.note.to_json)
-                .at_path("_embedded/details/0/value")
-      end
-    end
-
-    context "for a reminder when embedding" do
-      let(:reminder) { build_stubbed(:reminder) }
-      let(:reason) { :reminder }
-      let(:embed_links) { true }
-
-      before do
-        allow(notification).to receive(:reminder).and_return(reminder)
-      end
-
-      it_behaves_like "embeds a Values::Property for reminder note"
-    end
-
-    context "for a reminder when not embedding" do
-      let(:reminder) { build_stubbed(:reminder) }
-      let(:reason) { :reminder }
-      let(:embed_links) { false }
-
-      before do
-        allow(notification).to receive(:reminder).and_return(reminder)
-      end
-
-      it_behaves_like "embeds a Values::Property for reminder note"
-    end
-
-    context "for a reminder with no notification" do
-      let(:reminder) { nil }
-      let(:reason) { :reminder }
-
-      it "has an empty details array" do
-        expect(generated)
-          .to have_json_size(0)
-                .at_path("_embedded/details")
-      end
-    end
   end
 end