-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #14251 from opf/task/51022-revisit-the-create-stor…
…age-workflow A11y[Op#51022] Replace New Storage "magic form" with more accessible ActionMenu
- Loading branch information
Showing
20 changed files
with
180 additions
and
332 deletions.
There are no files selected for viewing
58 changes: 0 additions & 58 deletions
58
frontend/src/stimulus/controllers/dynamic/storages/select-provider-form.controller.ts
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 14 additions & 3 deletions
17
modules/storages/app/components/storages/admin/new_storage_button_component.html.erb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,17 @@ | ||
<%= | ||
render(Primer::Beta::Button.new(**button_options)) do |button| | ||
button.with_leading_visual_icon(icon: :plus) | ||
label | ||
render(Primer::Alpha::ActionMenu.new(test_selector: 'storages-select-provider-action-menu')) do |menu| | ||
menu.with_show_button(**show_button_options) do |button| | ||
button.with_leading_visual_icon(icon: :plus) | ||
button.with_trailing_action_icon(icon: :"triangle-down") | ||
label | ||
end | ||
|
||
::Storages::Storage::PROVIDER_TYPES.each do |provider_type| | ||
short_provider_type = ::Storages::Storage.shorten_provider_type(provider_type) | ||
menu.with_item( | ||
label: I18n.t("storages.provider_types.#{short_provider_type}.name"), | ||
href: select_provider_admin_settings_storages_path(provider: short_provider_type) | ||
) | ||
end | ||
end | ||
%> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 0 additions & 66 deletions
66
modules/storages/app/components/storages/admin/select_storage_provider_component.html.erb
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69 changes: 0 additions & 69 deletions
69
modules/storages/app/forms/storages/admin/provider_type_select_form.rb
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.