fix[Op#40437]: remove support for emoji reactions timeslicing

Emoji Reactions should always be returned in their current state, timeslicing will yield incorrect results.
At any given time, we ONLY need to know what reactions a Journal has. Further, EmojiReactions are never updated, rather created
and destroyed.

Retain timeslicing only for the journal render- where that is relevant to find updated journals

app/controllers/work_packages/activities_tab_controller.rb

@@ -315,8 +315,7 @@ def generate_time_based_update_streams(last_update_timestamp)
     end
 
     grouped_emoji_reactions = Journal.grouped_emoji_reactions_by_reactable(
-      reactable_id: journals.pluck(:id),
-      reactable_type: "Journal", last_updated_at: last_update_timestamp
+      reactable_id: journals.pluck(:id), reactable_type: "Journal"
     )
 
     rerender_updated_journals(journals, last_update_timestamp, grouped_emoji_reactions)

app/models/concerns/reactable.rb

@@ -38,12 +38,12 @@ def grouped_journal_emoji_reactions(journal)
       grouped_emoji_reactions_by_reactable(reactable_id: journal.id, reactable_type: "Journal")
     end
 
-    def grouped_work_package_journals_emoji_reactions(work_package, last_updated_at: nil)
-      grouped_emoji_reactions_by_reactable(reactable_id: work_package.journal_ids, reactable_type: "Journal", last_updated_at:)
+    def grouped_work_package_journals_emoji_reactions(work_package)
+      grouped_emoji_reactions_by_reactable(reactable_id: work_package.journal_ids, reactable_type: "Journal")
     end
 
-    def grouped_emoji_reactions_by_reactable(reactable_id:, reactable_type:, last_updated_at: nil)
-      grouped_emoji_reactions(reactable_id:, reactable_type:, last_updated_at:).each_with_object({}) do |row, hash|
+    def grouped_emoji_reactions_by_reactable(reactable_id:, reactable_type:)
+      grouped_emoji_reactions(reactable_id:, reactable_type:).each_with_object({}) do |row, hash|
         hash[row.reactable_id] ||= {}
         hash[row.reactable_id][row.reaction.to_sym] = {
           count: row.count,
@@ -52,15 +52,11 @@ def grouped_emoji_reactions_by_reactable(reactable_id:, reactable_type:, last_up
       end
     end
 
-    def grouped_emoji_reactions(reactable_id:, reactable_type:, last_updated_at: nil)
-      query = EmojiReaction
+    def grouped_emoji_reactions(reactable_id:, reactable_type:)
+      EmojiReaction
         .select(emoji_reactions_group_selection_sql)
         .joins(:user)
         .where(reactable_id:, reactable_type:)
-
-      query = query.where("emoji_reactions.updated_at > ?", last_updated_at) if last_updated_at
-
-      query
         .group("emoji_reactions.reactable_id, emoji_reactions.reaction")
         .order("first_created_at ASC")
     end

spec/models/concerns/reactable_spec.rb

@@ -73,22 +73,6 @@
       )
     end
 
-    context "when last_updated_at is set" do
-      it "returns grouped emoji reactions for work package journals that were updated after last_updated_at" do
-        wp_journal1.update!(updated_at: 1.day.ago)
-        result = Journal.grouped_work_package_journals_emoji_reactions(work_package, last_updated_at: wp_journal2.updated_at)
-
-        expect(result).to eq(
-          wp_journal2.id => {
-            thumbs_down: {
-              count: 1,
-              users: [{ id: user2.id, name: user2.name }]
-            }
-          }
-        )
-      end
-    end
-
     context "when no reactions exist" do
       it "returns an empty hash" do
         work_package = build_stubbed(:work_package)