Merge pull request #15744 from opf/bug/55431-display-an-error-when-du…

…ration-input-is-invalid

[#55431] Display an inline error when duration input is not a duration

app/controllers/work_packages/progress_controller.rb

@@ -131,13 +131,14 @@ def extract_persisted_progress_attributes
   def work_package_params
     params.require(:work_package)
           .permit(allowed_params).tap do |wp_params|
-      if wp_params["estimated_hours"].present?
-        wp_params["estimated_hours"] =
-          DurationConverter.parse(wp_params["estimated_hours"])
-      end
-      if wp_params["remaining_hours"].present?
-        wp_params["remaining_hours"] =
-          DurationConverter.parse(wp_params["remaining_hours"])
+      %w[estimated_hours remaining_hours].each do |attr|
+        if wp_params[attr].present?
+          begin
+            wp_params[attr] = DurationConverter.parse(wp_params[attr])
+          rescue ChronicDuration::DurationParseError
+            @work_package.errors.add(attr.to_sym, :invalid)
+          end
+        end
       end
     end
   end

app/services/duration_converter.rb

@@ -93,6 +93,7 @@ def parse(duration_string)
                        "hours"
                      end
 
+      ChronicDuration.raise_exceptions = true
       ChronicDuration.parse(duration_string,
                             keep_zero: true,
                             default_unit:,