Merge pull request #16044 from opf/maint/use-rubocop-openproject-gem

Move cops in opf/rubocop-openproject gem
opf · Jul 5, 2024 · 30fd0d4 · 30fd0d4
2 parents c5fe2d5 + 540a45c
commit 30fd0d4
Show file tree

Hide file tree

Showing 9 changed files with 6 additions and 475 deletions.
diff --git a/.github/workflows/rubocop-core.yml b/.github/workflows/rubocop-core.yml
@@ -19,6 +19,7 @@ jobs:
           rubocop_extensions: >
             rubocop-capybara:gemfile
             rubocop-factory_bot:gemfile
+            rubocop-openproject:gemfile
             rubocop-performance:gemfile
             rubocop-rails:gemfile
             rubocop-rspec:gemfile

diff --git a/.rubocop.yml b/.rubocop.yml
@@ -1,10 +1,8 @@
 require:
+  - rubocop-openproject
   - rubocop-rails
   - rubocop-rspec
   - rubocop-rspec_rails
-  - ./lib_static/rubocop/cop/open_project/add_preview_for_view_component.rb
-  - ./lib_static/rubocop/cop/open_project/no_do_end_block_with_rspec_capybara_matcher_in_expect.rb
-  - ./lib_static/rubocop/cop/open_project/use_service_result_factory_methods.rb
   - rubocop-capybara
   - rubocop-factory_bot
   - rubocop-performance

diff --git a/Gemfile b/Gemfile
@@ -331,6 +331,7 @@ group :development, :test do
   gem "rubocop", require: false
   gem "rubocop-capybara", require: false
   gem "rubocop-factory_bot", require: false
+  gem "rubocop-openproject", require: false
   gem "rubocop-performance", require: false
   gem "rubocop-rails", require: false
   gem "rubocop-rspec", require: false

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -986,6 +986,8 @@ GEM
       rubocop (~> 1.41)
     rubocop-factory_bot (2.26.1)
       rubocop (~> 1.61)
+    rubocop-openproject (0.1.0)
+      rubocop
     rubocop-performance (1.21.1)
       rubocop (>= 1.48.1, < 2.0)
       rubocop-ast (>= 1.31.1, < 2.0)
@@ -1312,6 +1314,7 @@ DEPENDENCIES
   rubocop
   rubocop-capybara
   rubocop-factory_bot
+  rubocop-openproject
   rubocop-performance
   rubocop-rails
   rubocop-rspec

diff --git a/lib_static/rubocop/cop/open_project/no_do_end_block_with_rspec_capybara_matcher_in_expect.rb b/lib_static/rubocop/cop/open_project/no_do_end_block_with_rspec_capybara_matcher_in_expect.rb
diff --git a/lib_static/rubocop/cop/open_project/use_service_result_factory_methods.rb b/lib_static/rubocop/cop/open_project/use_service_result_factory_methods.rb
diff --git a/...ib/rubocop/cop/open_project/no_do_end_block_with_rspec_capybara_matcher_in_expect_spec.rb b/...ib/rubocop/cop/open_project/no_do_end_block_with_rspec_capybara_matcher_in_expect_spec.rb