Remove feature flag for meeting update flash (#16759)

opf · Sep 20, 2024 · 35cf501 · 35cf501
1 parent 002ad82
commit 35cf501
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 7 deletions.
diff --git a/config/initializers/feature_decisions.rb b/config/initializers/feature_decisions.rb
@@ -43,9 +43,5 @@
                                                "Will be enabled by default in OpenProject 15.0. " \
                                                "See work package #52233 for more details."
 
-OpenProject::FeatureDecisions.add :meeting_updated_notification,
-                                  description: "Allow flash messages to notify users about concurrent meeting edits. " \
-                                               "See work package #54744 for more details."
-
 OpenProject::FeatureDecisions.add :built_in_oauth_applications,
                                   description: "Allows the display and use of built-in OAuth applications."
diff --git a/modules/meeting/app/components/meetings/header_component.html.erb b/modules/meeting/app/components/meetings/header_component.html.erb
@@ -10,7 +10,7 @@
     render(Primer::OpenProject::PageHeader.new(
       test_selector: "meeting-page-header",
       state: @state,
-      data: OpenProject::FeatureDecisions.meeting_updated_notification_active? ? params : {}
+      data: params
     )) do |header|
       header.with_title do |title|
         title.with_editable_form(model: @meeting,

diff --git a/modules/meeting/app/components/meetings/header_component.rb b/modules/meeting/app/components/meetings/header_component.rb
@@ -46,7 +46,7 @@ def initialize(meeting:, project: nil, state: STATE_DEFAULT)
 
     # Define the interval so it can be overriden through tests
     def check_for_updates_interval
-      OpenProject::FeatureDecisions.meeting_updated_notification_active? ? 10_000 : 0
+      10_000
     end
 
     private

diff --git a/modules/meeting/spec/features/structured_meetings/structured_meeting_update_flash_spec.rb b/modules/meeting/spec/features/structured_meetings/structured_meeting_update_flash_spec.rb
@@ -44,7 +44,7 @@
   let(:meeting) { create(:structured_meeting, project:, author: current_user) }
   let(:show_page) { Pages::StructuredMeeting::Show.new(meeting) }
 
-  describe "meeting update flash", with_flag: { meeting_updated_notification: true } do
+  describe "meeting update flash" do
     before do
       # Disable the polling so we can trigger it manually
       allow_any_instance_of(Meetings::HeaderComponent) # rubocop:disable RSpec/AnyInstance
-Original file line number
+Diff line change
@@ Expand Up / @@ -46,7 +46,7 @@ def initialize(meeting:, project: nil, state: STATE_DEFAULT) @@
         # Define the interval so it can be overriden through tests
         def check_for_updates_interval
-          OpenProject::FeatureDecisions.meeting_updated_notification_active? ? 10_000 : 0
+_000
         end
         private
@@ Expand Down @@