Merge pull request #14407 from opf/chore/speed-up-specs

Speed up a spec by using shared_let.
opf · Dec 13, 2023 · 36f1b19 · 36f1b19
2 parents 2c1a656 + f59855c
commit 36f1b19
Showing 1 changed file with 25 additions and 21 deletions.
diff --git a/modules/storages/spec/requests/api/v3/project_storages/project_storages_spec.rb b/modules/storages/spec/requests/api/v3/project_storages/project_storages_spec.rb
@@ -35,27 +35,25 @@
   let(:view_permissions) { %i(view_work_packages view_file_links) }
 
   # rubocop:disable RSpec/IndexedLet
-  let(:project1) { create(:project) }
-  let(:project2) { create(:project) }
-  let(:project3) { create(:project) }
-  let(:storage1) { create(:nextcloud_storage) }
-  let(:storage2) { create(:nextcloud_storage) }
-  let(:storage3) { create(:nextcloud_storage) }
-  let!(:project_storage11) { create(:project_storage, project: project1, storage: storage1) }
-  let!(:project_storage12) { create(:project_storage, project: project1, storage: storage2) }
-  let!(:project_storage13) { create(:project_storage, project: project1, storage: storage3) }
-  let!(:project_storage23) { create(:project_storage, project: project2, storage: storage3) }
-  let!(:project_storage21) { create(:project_storage, project: project2, storage: storage1) }
-  let!(:project_storage31) { create(:project_storage, project: project3, storage: storage1) }
+  shared_let(:project1) { create(:project) }
+  shared_let(:project2) { create(:project) }
+  shared_let(:project3) { create(:project) }
+  shared_let(:storage1) { create(:nextcloud_storage) }
+  shared_let(:storage2) { create(:nextcloud_storage) }
+  shared_let(:storage3) { create(:nextcloud_storage) }
+  shared_let(:project_storage11) { create(:project_storage, project: project1, storage: storage1) }
+  shared_let(:project_storage12) { create(:project_storage, project: project1, storage: storage2) }
+  shared_let(:project_storage13) { create(:project_storage, project: project1, storage: storage3) }
+  shared_let(:project_storage23) { create(:project_storage, project: project2, storage: storage3) }
+  shared_let(:project_storage21) { create(:project_storage, project: project2, storage: storage1) }
+  shared_let(:project_storage31) { create(:project_storage, project: project3, storage: storage1) }
   # rubocop:enable RSpec/IndexedLet
 
   subject(:last_response) do
     get path
   end
 
-  before do
-    login_as current_user
-  end
+  before { login_as current_user }
 
   describe 'GET /api/v3/project_storages' do
     let(:path) { api_v3_paths.project_storages }
@@ -267,13 +265,19 @@
       it_behaves_like 'redirect response'
 
       context 'if project storage has a configured project folder' do
-        let!(:project_storage12) do
-          create(:project_storage,
-                 project: project1,
-                 storage: storage2,
-                 project_folder_id: '1337',
-                 project_folder_mode: 'manual')
+        before(:all) do
+          project_storage12.update(
+            project_folder_id: '1337',
+            project_folder_mode: 'manual'
+          )
+        end
+        after(:all) do
+          project_storage12.update(
+            project_folder_id: nil,
+            project_folder_mode: 'inactive'
+          )
         end
+
         let(:path) { api_v3_paths.project_storage_open(project_storage12.id) }
 
         it_behaves_like 'redirect response' do