Move to request spec

modules/meeting/spec/features/recurring_meetings/recurring_meeting_crud_spec.rb

@@ -153,16 +153,6 @@
     show_page.expect_cancelled_actions date: "12/31/2024 01:30 PM"
   end
 
-  it "shows rescheduled occurrences" do
-    last = Meeting.reorder(id: :asc).last
-    last.start_time += 1.day
-    last.save!
-
-    show_page.visit!
-
-    show_page.expect_rescheduled_meeting old_date: "12/31/2024 01:30 PM", new_date: "01/01/2025 01:30 PM"
-  end
-
   context "with view permissions only" do
     let(:current_user) { other_user }
 

modules/meeting/spec/requests/recurring_meetings/recurring_meetings_index_spec.rb

@@ -0,0 +1,69 @@
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+require "spec_helper"
+
+RSpec.describe "Recurring meetings index",
+               :skip_csrf,
+               type: :rails_request do
+  shared_let(:project) { create(:project, enabled_module_names: %i[meetings]) }
+  shared_let(:user) { create(:user, member_with_permissions: { project => %i[view_meetings create_meetings edit_meetings] }) }
+  shared_let(:series) { create(:recurring_meeting, project:, author: user) }
+
+  let(:current_user) { user }
+
+  before do
+    login_as(current_user)
+  end
+
+  context "when user has permissions to access" do
+    it "does not show the recurring meetings" do
+      get recurring_meetings_path
+      expect(response).to have_http_status(:ok)
+    end
+
+    it "does not show project recurring meetings" do
+      get project_recurring_meetings_path(project)
+      expect(response).to have_http_status(:ok)
+    end
+  end
+
+  context "when user has no permissions to access" do
+    let(:current_user) { create(:user) }
+
+    it "does not show the recurring meetings" do
+      get recurring_meetings_path
+      expect(response).to have_http_status(:forbidden)
+    end
+
+    it "does not show project recurring meetings" do
+      get project_recurring_meetings_path(project)
+      expect(response).to have_http_status(:forbidden)
+    end
+  end
+end

modules/meeting/spec/requests/recurring_meetings/recurring_meetings_show_spec.rb

@@ -0,0 +1,155 @@
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+require "spec_helper"
+require_relative "../../support/pages/recurring_meeting/show"
+
+RSpec.describe "Recurring meetings show",
+               :skip_csrf,
+               type: :rails_request do
+  include Redmine::I18n
+
+  shared_let(:project) { create(:project, enabled_module_names: %i[meetings]) }
+  shared_let(:user) { create(:user, member_with_permissions: { project => %i[view_meetings create_meetings edit_meetings] }) }
+  shared_let(:recurring_meeting) do
+    create :recurring_meeting,
+           project:,
+           author: user,
+           start_time: Time.zone.today - 10.days + 10.hours,
+           frequency: "daily"
+  end
+
+  let(:current_user) { user }
+  let(:show_page) { Pages::RecurringMeeting::Show.new(recurring_meeting).with_capybara_page(page) }
+
+  before do
+    login_as(current_user)
+  end
+
+  context "when user has permissions to access" do
+    it "shows the recurring meetings" do
+      get recurring_meeting_path(recurring_meeting)
+      expect(response).to have_http_status(:ok)
+    end
+
+    it "shows project recurring meetings" do
+      get project_recurring_meeting_path(project, recurring_meeting)
+      expect(response).to have_http_status(:ok)
+    end
+  end
+
+  describe "past quick filter" do
+    let!(:past_instance) { create(:structured_meeting, recurring_meeting:, start_time: 1.day.ago + 10.hours) }
+    let!(:past_schedule) do
+      create :scheduled_meeting,
+             meeting: past_instance,
+             recurring_meeting:,
+             start_time: 1.day.ago + 10.hours
+    end
+
+    let!(:past_schedule_cancelled) do
+      create :scheduled_meeting,
+             recurring_meeting:,
+             start_time: 2.days.ago + 10.hours,
+             cancelled: true
+    end
+
+    it "does not show the cancelled meeting" do
+      get recurring_meeting_path(recurring_meeting, direction: "past")
+
+      expect(page).to have_text format_time(past_instance.start_time)
+      expect(page).to have_no_text format_time(past_schedule_cancelled.start_time)
+      expect(page).to have_no_css("li", text: "Cancelled")
+    end
+  end
+
+  describe "upcoming quick filter" do
+    context "with a rescheduled meeting" do
+      let!(:rescheduled_instance) do
+        create :structured_meeting,
+               recurring_meeting:,
+               start_time: Time.zone.today + 2.days + 10.hours
+      end
+      let!(:rescheduled) do
+        create :scheduled_meeting,
+               meeting: rescheduled_instance,
+               recurring_meeting:,
+               start_time: Time.zone.today + 1.day + 10.hours
+      end
+
+      it "shows rescheduled occurrences" do
+        get recurring_meeting_path(recurring_meeting)
+
+        old_date = format_time(rescheduled.start_time)
+        new_date = format_time(rescheduled_instance.start_time)
+        expect(page).to have_css("li s", text: old_date)
+        expect(page).to have_text("#{old_date}\n#{new_date}")
+      end
+    end
+
+    context "with a cancelled meeting" do
+      let!(:rescheduled) do
+        create :scheduled_meeting,
+               :cancelled,
+               recurring_meeting:,
+               start_time: Time.zone.today + 1.day + 10.hours
+      end
+
+      it "shows the cancelled occurrences" do
+        get recurring_meeting_path(recurring_meeting)
+
+        expect(page).to have_css("li", text: format_time(rescheduled.start_time))
+        expect(page).to have_css("li", text: "Cancelled")
+      end
+    end
+
+    context "with no scheduled meetings" do
+      it "shows the next five occurrences" do
+        get recurring_meeting_path(recurring_meeting)
+
+        (1..5).each do |date|
+          expect(page).to have_text format_time(Time.zone.today + date.days + 10.hours)
+        end
+      end
+    end
+  end
+
+  context "when user has no permissions to access" do
+    let(:current_user) { create(:user) }
+
+    it "does not show the recurring meetings" do
+      get recurring_meeting_path(recurring_meeting)
+      expect(response).to have_http_status(:not_found)
+    end
+
+    it "does not show project recurring meetings" do
+      get project_recurring_meeting_path(project, recurring_meeting)
+      expect(response).to have_http_status(:not_found)
+    end
+  end
+end

modules/meeting/spec/support/pages/recurring_meeting/show.rb

@@ -76,6 +76,12 @@ def expect_cancelled_meeting(date:)
       end
     end
 
+    def expect_no_cancelled_meeting(date:)
+      within("li", text: date) do
+        expect(page).to have_no_css(".status", text: "Cancelled")
+      end
+    end
+
     def expect_rescheduled_meeting(old_date:, new_date:)
       within("li", text: old_date) do
         expect(page).to have_css("s", text: old_date)
@@ -111,6 +117,10 @@ def in_edit_dialog(&)
       page.within("#new-meeting-dialog", &)
     end
 
+    def expect_no_meeting(date:)
+      expect(page).to have_no_css("li", text: date)
+    end
+
     def expect_no_actions(date:)
       within("li", text: date) do
         expect(page).not_to have_test_selector("more-button")