Replace opHighlightCol with stimulus controller

opf · Aug 14, 2024 · 5b3f3a2 · 5b3f3a2
1 parent 04a202a
commit 5b3f3a2
Show file tree

Hide file tree

Showing 57 changed files with 301 additions and 304 deletions.
diff --git a/app/components/projects/table_component.html.erb b/app/components/projects/table_component.html.erb
@@ -31,10 +31,10 @@ See COPYRIGHT and LICENSE files for more details.
   <div class="generic-table--flex-container">
     <div class="generic-table--container <%= container_class %>">
       <div class="generic-table--results-container">
-        <table class="generic-table" <%= table_id ? "id=\"#{table_id}\"".html_safe : '' %>>
+        <table class="generic-table" data-controller="table-highlighting" <%= table_id ? "id=\"#{table_id}\"".html_safe : '' %>>
           <colgroup>
             <% columns.each do |column| %>
-              <col <%= "opHighlightCol" unless column.attribute == :hierarchy %> >
+              <col>
             <% end %>
             <col>
           </colgroup>

diff --git a/app/components/table_component.html.erb b/app/components/table_component.html.erb
@@ -29,10 +29,10 @@ See COPYRIGHT and LICENSE files for more details.
 
 <div class="generic-table--container <%= container_class %>" data-test-selector="<%= test_selector %>">
   <div class="generic-table--results-container">
-    <table class="generic-table">
+    <table class="generic-table" data-controller="table-highlighting">
       <colgroup>
         <% headers.each do |_name, _options| %>
-          <col opHighlightCol>
+          <col>
         <% end %>
         <col>
       </colgroup>

diff --git a/app/views/attribute_help_texts/_tab.html.erb b/app/views/attribute_help_texts/_tab.html.erb
@@ -2,11 +2,11 @@
 <% if entries.any? %>
   <div class="generic-table--container">
     <div class="generic-table--results-container">
-      <table class="generic-table">
+      <table class="generic-table" data-controller="table-highlighting">
         <colgroup>
-          <col opHighlightCol>
-          <col opHighlightCol>
-          <col opHighlightCol>
+          <col>
+          <col>
+          <col>
           <col>
         </colgroup>
         <thead>

diff --git a/app/views/custom_fields/_custom_options.html.erb b/app/views/custom_fields/_custom_options.html.erb
@@ -32,11 +32,11 @@ See COPYRIGHT and LICENSE files for more details.
 
 <div class="generic-table--container">
   <div class="generic-table--results-container">
-    <table class="generic-table" id="custom-options-table">
+    <table class="generic-table" id="custom-options-table" data-controller="table-highlighting">
       <colgroup>
-        <col opHighlightCol>
-        <col opHighlightCol>
-        <col opHighlightCol>
+        <col>
+        <col>
+        <col>
         <col>
       </colgroup>
       <thead>

diff --git a/app/views/custom_fields/_tab.html.erb b/app/views/custom_fields/_tab.html.erb
@@ -50,16 +50,16 @@ See COPYRIGHT and LICENSE files for more details.
           </div>
         </div>
       <% end %>
-      <table class="generic-table">
+      <table class="generic-table" data-controller="table-highlighting">
         <colgroup>
-          <col opHighlightCol>
-          <col opHighlightCol>
+          <col>
+          <col>
           <% if tab[:name] == 'WorkPackageCustomField' %>
-            <col opHighlightCol>
-            <col opHighlightCol>
+            <col>
+            <col>
           <% end %>
-          <col opHighlightCol>
-          <col opHighlightCol>
+          <col>
+          <col>
           <col>
         </colgroup>
         <thead>

diff --git a/app/views/forums/index.html.erb b/app/views/forums/index.html.erb
@@ -46,14 +46,14 @@ See COPYRIGHT and LICENSE files for more details.
 <% else %>
   <div class="generic-table--container">
     <div class="generic-table--results-container">
-      <table class="generic-table boards">
+      <table class="generic-table boards" data-controller="table-highlighting">
         <colgroup>
-          <col opHighlightCol>
-          <col opHighlightCol>
-          <col opHighlightCol>
-          <col opHighlightCol>
+          <col>
+          <col>
+          <col>
+          <col>
           <% if User.current.allowed_in_project?(:manage_forums, @project) %>
-            <col opHighlightCol>
+            <col>
             <col>
           <% end %>
         </colgroup>

diff --git a/app/views/forums/show.html.erb b/app/views/forums/show.html.erb
@@ -69,13 +69,13 @@ See COPYRIGHT and LICENSE files for more details.
 <% if @topics.any? %>
   <div class="generic-table--container">
     <div class="generic-table--results-container">
-      <table class="generic-table">
+      <table class="generic-table" data-controller="table-highlighting">
         <colgroup>
-          <col opHighlightCol>
-          <col opHighlightCol>
-          <col opHighlightCol>
-          <col opHighlightCol>
-          <col opHighlightCol>
+          <col>
+          <col>
+          <col>
+          <col>
+          <col>
         </colgroup>
         <thead>
         <tr>

diff --git a/app/views/groups/_memberships.html.erb b/app/views/groups/_memberships.html.erb
@@ -35,10 +35,10 @@ See COPYRIGHT and LICENSE files for more details.
     <% if @group.memberships.any? %>
       <div class="generic-table--container">
         <div class="generic-table--results-container">
-          <table class="generic-table memberships">
+          <table class="generic-table memberships" data-controller="table-highlighting">
             <colgroup>
-              <col opHighlightCol>
-              <col opHighlightCol>
+              <col>
+              <col>
               <col>
             </colgroup>
             <thead>

diff --git a/app/views/groups/_users_table.html.erb b/app/views/groups/_users_table.html.erb
@@ -29,7 +29,7 @@ See COPYRIGHT and LICENSE files for more details.
 
 <table class="generic-table users">
   <colgroup>
-    <col opHighlightCol>
+    <col colightCol>
     <col>
   </colgroup>
   <thead>

diff --git a/app/views/groups/index.html.erb b/app/views/groups/index.html.erb
@@ -54,10 +54,10 @@ See COPYRIGHT and LICENSE files for more details.
 <% if @groups.any? %>
   <div class="generic-table--container">
     <div class="generic-table--results-container">
-      <table class="generic-table">
+      <table class="generic-table" data-controller="table-highlighting">
         <colgroup>
-          <col opHighlightCol>
-          <col opHighlightCol>
+          <col>
+          <col>
           <col>
         </colgroup>
         <thead>

diff --git a/app/views/individual_principals/_memberships.html.erb b/app/views/individual_principals/_memberships.html.erb
@@ -40,8 +40,8 @@ See COPYRIGHT and LICENSE files for more details.
       <div class="generic-table--results-container">
         <table class="generic-table memberships">
           <colgroup>
-            <col opHighlightCol>
-            <col opHighlightCol>
+            <col>
+            <col>
             <%= call_individual_principals_memberships_hook(@individual_principal, 'colgroup') %>
             <col>
           </colgroup>

diff --git a/app/views/my/access_token.html.erb b/app/views/my/access_token.html.erb
@@ -52,9 +52,8 @@ See COPYRIGHT and LICENSE files for more details.
 %>
 <div class="generic-table--container">
   <div class="generic-table--results-container">
-    <table class="generic-table">
+    <table class="generic-table" data-controller="table-highlighting">
       <%= call_hook(:view_access_tokens_table, user: @user) %>
     </table>
   </div>
 </div>
-
diff --git a/app/views/my/access_token_partials/_icalendar_tokens_section.html.erb b/app/views/my/access_token_partials/_icalendar_tokens_section.html.erb
@@ -40,17 +40,17 @@ See COPYRIGHT and LICENSE files for more details.
       <% if ical_tokens_grouped_by_query.any? %>
         <div class="generic-table--container">
           <div class="generic-table--results-container">
-            <table class="generic-table">
+            <table class="generic-table" data-controller="table-highlighting">
               <%= render  partial: "my/access_token_partials/token_table_header",
-                          locals: { 
+                          locals: {
                             column_headers: [
                               t('attributes.name'),
                               WorkPackage.human_attribute_name(:calendar),
                               WorkPackage.human_attribute_name(:project),
                               User.human_attribute_name(:created_at),
                               t('my_account.access_tokens.headers.expiration')
-                            ] 
-                          } 
+                            ]
+                          }
               %>
               <tbody>
                 <% ical_tokens_grouped_by_query.each do |query_id, tokens| %>
@@ -103,5 +103,3 @@ See COPYRIGHT and LICENSE files for more details.
     <% end %>
   </div>
 </div>
-
-
diff --git a/app/views/my/access_token_partials/_oauth_tokens_section.html.erb b/app/views/my/access_token_partials/_oauth_tokens_section.html.erb
@@ -39,15 +39,15 @@ See COPYRIGHT and LICENSE files for more details.
     <% if granted_applications.any? %>
       <div class="generic-table--container">
         <div class="generic-table--results-container">
-          <table class="generic-table">
+          <table class="generic-table" data-controller="table-highlighting">
             <%= render  partial: "my/access_token_partials/token_table_header",
-                        locals: { 
+                        locals: {
                           column_headers: [
-                            t('attributes.name'), 
+                            t('attributes.name'),
                             User.human_attribute_name(:created_at),
                             t('my_account.access_tokens.headers.expiration')
-                          ] 
-                        } 
+                          ]
+                        }
             %>
             <tbody>
               <% granted_applications.each do |application, tokens| %>

diff --git a/app/views/my/access_token_partials/_rss_tokens_section.html.erb b/app/views/my/access_token_partials/_rss_tokens_section.html.erb
@@ -40,15 +40,15 @@ See COPYRIGHT and LICENSE files for more details.
       <% if rss_token %>
         <div class="generic-table--container">
           <div class="generic-table--results-container">
-            <table class="generic-table">
+            <table class="generic-table" data-controller="table-highlighting">
               <%= render  partial: "my/access_token_partials/token_table_header",
-                          locals: { 
+                          locals: {
                             column_headers: [
-                              t('attributes.name'), 
-                              User.human_attribute_name(:created_at), 
+                              t('attributes.name'),
+                              User.human_attribute_name(:created_at),
                               t('my_account.access_tokens.headers.expiration')
-                            ] 
-                          } 
+                            ]
+                          }
               %>
               <tbody>
                 <tr>
@@ -88,5 +88,3 @@ See COPYRIGHT and LICENSE files for more details.
     <% end %>
   </div>
 </div>
-
-
diff --git a/app/views/my/access_token_partials/_storage_tokens_section.html.erb b/app/views/my/access_token_partials/_storage_tokens_section.html.erb
@@ -39,7 +39,7 @@ See COPYRIGHT and LICENSE files for more details.
     <% if @storage_tokens.any? %>
       <div class="generic-table--container">
         <div class="generic-table--results-container">
-          <table class="generic-table">
+          <table class="generic-table" data-controller="table-highlighting">
             <%= render  partial: "my/access_token_partials/token_table_header",
                         locals: {
                           column_headers: [

diff --git a/app/views/my/access_token_partials/_token_table_header.html.erb b/app/views/my/access_token_partials/_token_table_header.html.erb
@@ -28,9 +28,9 @@ See COPYRIGHT and LICENSE files for more details.
 ++#%>
 <colgroup>
   <% column_headers&.length&.times do %>
-    <col opHighlightCol>
+    <col>
   <% end %>
-  <col opHighlightCol>
+  <col>
 </colgroup>
 <thead>
   <tr>
@@ -49,4 +49,4 @@ See COPYRIGHT and LICENSE files for more details.
       </div>
     </th>
   </tr>
-</thead>
+</thead>
diff --git a/app/views/principals/_global_roles.html.erb b/app/views/principals/_global_roles.html.erb
@@ -39,9 +39,9 @@ See COPYRIGHT and LICENSE files for more details.
   <% else %>
     <div class="generic-table--container">
       <div class="generic-table--results-container">
-        <table class="generic-table principal_roles" id="table_principal_roles">
+        <table class="generic-table principal_roles" id="table_principal_roles" data-controller="table-highlighting">
           <colgroup>
-            <col opHighlightCol>
+            <col>
             <col>
           </colgroup>
           <thead>

diff --git a/app/views/projects/settings/categories/show.html.erb b/app/views/projects/settings/categories/show.html.erb
@@ -44,10 +44,10 @@ See COPYRIGHT and LICENSE files for more details.
 <% if @project.categories.any? %>
   <div class="generic-table--container">
     <div class="generic-table--results-container">
-      <table class="generic-table">
+      <table class="generic-table" data-controller="table-highlighting">
         <colgroup>
-          <col opHighlightCol>
-          <col opHighlightCol>
+          <col>
+          <col>
           <col>
         </colgroup>
         <thead>

diff --git a/app/views/projects/settings/custom_fields/_form.html.erb b/app/views/projects/settings/custom_fields/_form.html.erb
@@ -29,11 +29,11 @@ See COPYRIGHT and LICENSE files for more details.
 
 <div class="generic-table--container">
   <div class="generic-table--results-container">
-    <table class="generic-table">
+    <table class="generic-table" data-controller="table-highlighting">
       <colgroup>
-        <col opHighlightCol>
-        <col opHighlightCol>
-        <col opHighlightCol>
+        <col>
+        <col>
+        <col>
         </colgroup>
         <thead>
           <tr>

diff --git a/app/views/projects/settings/types/_form.html.erb b/app/views/projects/settings/types/_form.html.erb
@@ -29,13 +29,13 @@ See COPYRIGHT and LICENSE files for more details.
 
 <div class="generic-table--container">
   <div class="generic-table--results-container">
-    <table class="generic-table types">
+    <table class="generic-table types" data-controller="table-highlighting">
       <colgroup>
-        <col opHighlightCol>
-        <col opHighlightCol>
-        <col opHighlightCol>
-        <col opHighlightCol>
-        <col opHighlightCol>
+        <col>
+        <col>
+        <col>
+        <col>
+        <col>
       </colgroup>
       <thead>
         <tr>

diff --git a/app/views/repositories/_dir_list.html.erb b/app/views/repositories/_dir_list.html.erb
@@ -28,15 +28,15 @@ See COPYRIGHT and LICENSE files for more details.
 ++#%>
 <div class="generic-table--container">
   <div class="generic-table--results-container">
-    <table class="generic-table" data-repository-navigation-target="repoBrowser">
+    <table class="generic-table" data-controller="table-highlighting" data-repository-navigation-target="repoBrowser">
       <colgroup>
-        <col opHighlightCol>
         <col>
-        <col opHighlightCol>
-        <col opHighlightCol>
-        <col opHighlightCol>
-        <col opHighlightCol>
-        <col opHighlightCol>
+        <col>
+        <col>
+        <col>
+        <col>
+        <col>
+        <col>
       </colgroup>
       <thead>
         <tr id="root">

diff --git a/app/views/repositories/_revisions.html.erb b/app/views/repositories/_revisions.html.erb
@@ -32,12 +32,12 @@ See COPYRIGHT and LICENSE files for more details.
     <div class="generic-table--results-container">
       <table class="generic-table changesets">
         <colgroup>
-          <col opHighlightCol>
           <col>
           <col>
-          <col opHighlightCol>
-          <col opHighlightCol>
-          <col opHighlightCol>
+          <col>
+          <col>
+          <col>
+          <col>
         </colgroup>
         <caption class="hidden-for-sighted">
           <span>