Merge pull request #17309 from opf/bug/59795-missing-space-between-pr…

…oject-selector-and-include-sub-projects-checkbox [59795] Missing space between project selector and "include sub-projects"-checkbox
opf · Dec 2, 2024 · 5b4f8ce · 5b4f8ce
2 parents 4101227 + f832395
commit 5b4f8ce
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/...stom_fields/custom_field_projects/new_custom_field_projects_form_modal_component.html.erb b/...stom_fields/custom_field_projects/new_custom_field_projects_form_modal_component.html.erb
@@ -37,7 +37,7 @@ See COPYRIGHT and LICENSE files for more details.
     ) do |form|
       concat(render(Primer::Alpha::Dialog::Body.new(
         id: dialog_body_id, test_selector: dialog_body_id, aria: { label: title },
-        style: "min-height: 300px"
+        classes: "Overlay-body_autocomplete_height"
       )) do
         render(Projects::CustomFields::CustomFieldMappingForm.new(form, project_mapping: @custom_field_project_mapping))
       end)

diff --git a/app/forms/projects/custom_fields/custom_field_mapping_form.rb b/app/forms/projects/custom_fields/custom_field_mapping_form.rb
@@ -31,8 +31,7 @@ class CustomFieldMappingForm < ApplicationForm
     include OpPrimer::ComponentHelpers
 
     form do |form|
-      form.group(layout: :vertical) do |group|
-        group.project_autocompleter(
+      form.project_autocompleter(
           name: :id,
           label: Project.model_name.human,
           visually_hide_label: true,
@@ -48,13 +47,12 @@ class CustomFieldMappingForm < ApplicationForm
           }
         )
 
-        group.check_box(
+      form.check_box(
           name: :include_sub_projects,
           label: I18n.t(:label_include_sub_projects),
           checked: false,
           label_arguments: { class: "no-wrap" }
         )
-      end
     end
 
     def initialize(project_mapping:)