adapt spec setup

modules/boards/spec/features/menu_items/global_menu_item_spec.rb

@@ -32,6 +32,7 @@
 require "spec_helper"
 
 RSpec.describe "Global menu item for boards", :js, :with_cuprite do
+  shared_let(:project) { create(:project) }
   let(:boards_label) { I18n.t("boards.label_boards") }
 
   before do

modules/boards/spec/features/menu_items/top_menu_item_spec.rb

@@ -29,15 +29,12 @@
 require "spec_helper"
 
 RSpec.describe "Top menu item for boards", :js, :with_cuprite do
-  let(:user) { create(:admin) }
+  current_user { create(:admin) }
+  shared_let(:project) { create(:project) }
 
   let(:menu) { find(".op-app-menu a[title='#{I18n.t('label_modules')}']") }
   let(:boards) { I18n.t("boards.label_boards") }
 
-  before do
-    allow(User).to receive(:current).and_return user
-  end
-
   shared_examples_for "the boards menu item" do
     it "sends the user to the boards overview when clicked" do
       menu.click
@@ -52,8 +49,6 @@
   end
 
   context "when in the project settings" do
-    let!(:project) { create(:project) }
-
     before do
       visit "/projects/#{project.identifier}/settings/general"
     end

modules/meeting/spec/controllers/meetings_controller_spec.rb

@@ -29,19 +29,11 @@
 require "#{File.dirname(__FILE__)}/../spec_helper"
 
 RSpec.describe MeetingsController do
-  let(:user) { create(:admin) }
-  let(:project) { create(:project) }
-  let(:other_project) { create(:project) }
+  shared_let(:user) { create(:admin) }
+  shared_let(:project) { create(:project) }
+  shared_let(:other_project) { create(:project) }
 
-  before do
-    allow(User).to receive(:current).and_return user
-
-    allow(Project).to receive(:find).and_return(project)
-
-    allow(controller).to receive(:authorize)
-    allow(controller).to receive(:authorize_global)
-    allow(controller).to receive(:check_if_login_required)
-  end
+  current_user { user }
 
   describe "GET" do
     describe "index" do
@@ -161,8 +153,6 @@
       let(:meeting_params) { base_meeting_params }
 
       before do
-        allow(Project).to receive(:find).and_return(project)
-
         post :create,
              params:
       end

modules/meeting/spec/features/meetings_global_menu_item_spec.rb

@@ -36,6 +36,7 @@
                :with_cuprite do
   shared_let(:user_without_permissions) { create(:user) }
   shared_let(:admin) { create(:admin) }
+  shared_let(:project) { create(:project) }
   shared_let(:meetings_label) { I18n.t(:label_meeting_plural) }
 
   let(:meetings_page) { Pages::Meetings::Index.new(project: nil) }

modules/reporting/spec/features/top_menu_item_spec.rb

@@ -29,6 +29,8 @@
 require "spec_helper"
 
 RSpec.describe "Top menu items", :js do
+  shared_let(:project) { create(:project) }
+
   let(:user) { create(:user) }
   let(:open_menu) { true }
 

modules/reporting/spec/workers/cost_query/export_job_spec.rb

@@ -31,7 +31,7 @@
 require "spec_helper"
 
 RSpec.describe CostQuery::ExportJob do
-  let(:user) { build_stubbed(:admin) }
+  let(:user) { build_stubbed(:user) }
   let(:project) { build_stubbed(:project) }
 
   let(:initial_filter_params) do
@@ -46,6 +46,10 @@
     }
   end
 
+  before do
+    mock_permissions_for(user, &:allow_everything)
+  end
+
   # Performs a cost export with the given extra filters.
   #
   # @param extra_filters [Hash] A hash of attribute names and operator/value

spec/controllers/activities_controller_spec.rb

@@ -30,6 +30,8 @@
 
 RSpec.describe ActivitiesController do
   shared_let(:admin) { create(:admin) }
+  shared_let(:project) { create(:project) }
+
   current_user { admin }
 
   before do

spec/controllers/news_controller_spec.rb

@@ -33,15 +33,10 @@
 
   include BecomeMember
 
-  let(:user) do
-    create(:admin)
-  end
-  let(:project) { create(:project) }
   let(:news) { create(:news) }
 
-  before do
-    allow(User).to receive(:current).and_return user
-  end
+  shared_let(:project) { create(:project) }
+  current_user { create(:admin) }
 
   describe "#index" do
     it "renders index" do
@@ -101,7 +96,7 @@
   describe "#create" do
     context "with news_added notifications" do
       it "persists a news item" do
-        become_member(project, user)
+        become_member(project, current_user)
 
         post :create,
              params: {
@@ -117,7 +112,7 @@
         news = News.find_by!(title: "NewsControllerTest")
         expect(news).not_to be_nil
         expect(news.description).to eq "This is the description"
-        expect(news.author).to eq user
+        expect(news.author).to eq current_user
         expect(news.project).to eq project
       end
     end

spec/features/custom_fields/create_long_text_spec.rb

@@ -6,7 +6,7 @@
   let(:cf_page) { Pages::CustomFields.new }
   let(:editor) { Components::WysiwygEditor.new "#custom_field_form" }
   let(:type) { create(:type_task) }
-  let(:project) { create(:project, enabled_module_names: %i[work_package_tracking], types: [type]) }
+  let!(:project) { create(:project, enabled_module_names: %i[work_package_tracking], types: [type]) }
 
   let(:wp_page) { Pages::FullWorkPackageCreate.new project: }
 

spec/features/news/global_menu_item_spec.rb

@@ -34,6 +34,7 @@
 RSpec.describe "News global menu item spec", :js, :with_cuprite do
   shared_let(:admin) { create(:admin) }
   shared_let(:user_without_permissions) { create(:user) }
+  shared_let(:project) { create(:project) }
 
   before do
     login_as current_user

spec/features/projects/global_menu_item_spec.rb

@@ -32,10 +32,10 @@
 require "spec_helper"
 
 RSpec.describe "Projects global menu item", :js, :with_cuprite do
-  let(:user) { create(:user) }
+  current_user { create(:user) }
+  shared_let(:project) { create(:project) }
 
   before do
-    login_as user
     visit root_path
   end
 

spec/features/types/form_configuration_spec.rb

@@ -32,7 +32,7 @@
   shared_let(:admin) { create(:admin) }
   let(:type) { create(:type) }
 
-  let(:project) { create(:project, types: [type]) }
+  let!(:project) { create(:project, types: [type]) }
   let(:category) { create(:category, project:) }
   let(:work_package) do
     create(:work_package,

spec/features/work_packages/work_package_index_spec.rb

@@ -29,13 +29,12 @@
 require "spec_helper"
 
 RSpec.describe "Work Packages", "index view", :js, :with_cuprite do
-  let(:user) { create(:admin) }
-  let(:project) { create(:project, enabled_module_names: %w[work_package_tracking]) }
+  shared_let(:user) { create(:admin) }
+  shared_let(:project) { create(:project, enabled_module_names: %w[work_package_tracking]) }
+
   let(:wp_table) { Pages::WorkPackagesTable.new(project) }
 
-  before do
-    login_as(user)
-  end
+  current_user { user }
 
   context "within a global context" do
     before do

spec/requests/rate_limiting/api_v3_rate_limiting_spec.rb

@@ -33,6 +33,7 @@
   include Rack::Test::Methods
   include API::V3::Utilities::PathHelper
 
+  shared_let(:project) { create(:project) }
   current_user { create(:admin) }
 
   context "when enabled", with_config: { rate_limiting: { api_v3: true } } do