Skip to content

Commit

Permalink
Ensure scan phase fails if brakeman segfaults
Browse files Browse the repository at this point in the history
brakeman segfaulted in a CI job, and it was not noticed because of
`continue-on-error: true`. Using `--no-exit-on-warn` and
`--no-exit-on-error` allows to remove the `continue-on-error: true`
parameter.
  • Loading branch information
cbliard authored and oliverguenther committed Mar 1, 2023
1 parent e0f67b0 commit 98be78b
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions .github/workflows/brakeman-scan-core.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,13 @@ jobs:
gem install brakeman
- name: Scan
continue-on-error: true
run: |
brakeman -i config/brakeman.ignore -f sarif -o output.sarif.json .
brakeman \
--ignore-config config/brakeman.ignore \
--no-exit-on-warn \
--no-exit-on-error \
--format sarif \
--output output.sarif.json
- name: Upload SARIF
uses: github/codeql-action/upload-sarif@v2
Expand Down

0 comments on commit 98be78b

Please sign in to comment.