chore[Op#53019]: rubocop amend modules/gitlab_integration

modules/gitlab_integration/app/models/gitlab_issue.rb

@@ -50,7 +50,7 @@ class GitlabIssue < ApplicationRecord
                         unless: :partial?
   validate :validate_labels_schema
 
-  scope :without_work_package, -> { left_outer_joins(:work_packages).where(work_packages: { id: nil }) }
+  scope :without_work_package, -> { where.missing(:work_packages) }
 
   def self.find_by_gitlab_identifiers(id: nil, url: nil, initialize: false)
     raise ArgumentError, "needs an id or an url" if id.nil? && url.blank?

modules/gitlab_integration/app/models/gitlab_merge_request.rb

@@ -53,7 +53,7 @@ class GitlabMergeRequest < ApplicationRecord
                         unless: :partial?
   validate :validate_labels_schema
 
-  scope :without_work_package, -> { left_outer_joins(:work_packages).where(work_packages: { id: nil }) }
+  scope :without_work_package, -> { where.missing(:work_packages) }
 
   def self.find_by_gitlab_identifiers(id: nil, url: nil, initialize: false)
     raise ArgumentError, "needs an id or an url" if id.nil? && url.blank?

modules/gitlab_integration/db/migrate/20211015110000_gitlab_integration_models.rb

@@ -33,7 +33,7 @@ def change
       t.references :gitlab_user
       t.references :merged_by
 
-      t.bigint :gitlab_id, unique: true 
+      t.bigint :gitlab_id, unique: true
       t.integer :number, null: false
       t.string :gitlab_html_url, null: false, unique: true
       t.string :state, null: false
@@ -45,6 +45,7 @@ def change
       t.boolean :merged
       t.datetime :merged_at
       t.json :labels # [{name, color}]
+
       t.timestamps
     end
 
@@ -55,7 +56,6 @@ def change
               name: "unique_index_gl_mrs_wps_on_gl_mr_id_and_wp_id"
     end
 
-
     create_table :gitlab_users do |t|
       t.bigint :gitlab_id, null: false, unique: true
       t.string :gitlab_name, null: false
@@ -66,14 +66,13 @@ def change
       t.timestamps
     end
 
-
     create_table :gitlab_pipelines do |t|
       t.references :gitlab_merge_request, null: false
 
       t.bigint :gitlab_id, null: false, unique: true
       t.string :gitlab_html_url, null: false
-      t.bigint :project_id, null: false 
-      t.string :gitlab_user_avatar_url, null: false 
+      t.bigint :project_id, null: false
+      t.string :gitlab_user_avatar_url, null: false
       t.string :status, null: false
       t.string :name, null: false
       t.string :details_url

modules/gitlab_integration/db/migrate/20211015110002_add_gitlab_issues.rb

@@ -27,12 +27,11 @@
 # See docs/COPYRIGHT.rdoc for more details.
 #++
 class AddGitlabIssues < ActiveRecord::Migration[7.0]
-  # rubocop:disable Metrics/AbcSize
   def change
     create_table :gitlab_issues do |t|
       t.references :gitlab_user
 
-      t.bigint :gitlab_id, unique: true 
+      t.bigint :gitlab_id, unique: true
       t.integer :number, null: false
       t.string :gitlab_html_url, null: false, unique: true
       t.string :state, null: false
@@ -41,6 +40,7 @@ def change
       t.string :title
       t.text :body
       t.json :labels # [{name, color}]
+
       t.timestamps
     end
 
@@ -50,7 +50,5 @@ def change
               unique: true,
               name: "unique_index_gl_issues_wps_on_gl_issue_id_and_wp_id"
     end
-
   end
-  # rubocop:enable Metrics/AbcSize
 end

modules/gitlab_integration/lib/api/v3/gitlab_issues/gitlab_issue_representer.rb

@@ -42,7 +42,7 @@ class GitlabIssueRepresenter < ::API::Decorators::Single
         def initialize(model, current_user:, **_opts)
           # We force `embed_links` so that github_user and github_check_runs
           # are embedded and we can avoid having separate endpoints.
-          super(model, current_user: current_user, embed_links: true)
+          super(model, current_user:, embed_links: true)
         end
 
         cached_representer key_parts: %i[gitlab_user]
@@ -61,7 +61,7 @@ def initialize(model, current_user:, **_opts)
 
         date_time_property :gitlab_updated_at,
                            render_nil: true,
-                           setter: ->(*) { nil }
+                           setter: ->(*) {}
 
         property :title,
                  render_nil: true

modules/gitlab_integration/lib/api/v3/gitlab_issues/gitlab_user_representer.rb

@@ -37,7 +37,7 @@ class GitlabUserRepresenter < ::API::Decorators::Single
         include API::Caching::CachedRepresenter
 
         self_link id_attribute: :id,
-                  title_getter: ->(*) { nil }
+                  title_getter: ->(*) {}
 
         property :gitlab_name, as: :login
         property :gitlab_email, as: :email

modules/gitlab_integration/lib/api/v3/gitlab_merge_requests/gitlab_merge_request_representer.rb

@@ -42,7 +42,7 @@ class GitlabMergeRequestRepresenter < ::API::Decorators::Single
         def initialize(model, current_user:, **_opts)
           # We force `embed_links` so that github_user and github_check_runs
           # are embedded and we can avoid having separate endpoints.
-          super(model, current_user: current_user, embed_links: true)
+          super(model, current_user:, embed_links: true)
         end
 
         cached_representer key_parts: %i[gitlab_user merged_by]
@@ -61,7 +61,7 @@ def initialize(model, current_user:, **_opts)
 
         date_time_property :gitlab_updated_at,
                            render_nil: true,
-                           setter: ->(*) { nil }
+                           setter: ->(*) {}
 
         property :title,
                  render_nil: true

modules/gitlab_integration/lib/api/v3/gitlab_merge_requests/gitlab_pipeline_representer.rb

@@ -38,7 +38,7 @@ class GitlabPipelineRepresenter < ::API::Decorators::Single
         include API::Decorators::DateProperty
 
         self_link id_attribute: :id,
-                  title_getter: ->(*) { nil }
+                  title_getter: ->(*) {}
 
         property :gitlab_html_url, as: :htmlUrl
         property :gitlab_user_avatar_url, as: :userAvatarUrl

modules/gitlab_integration/lib/api/v3/gitlab_merge_requests/gitlab_user_representer.rb

@@ -37,7 +37,7 @@ class GitlabUserRepresenter < ::API::Decorators::Single
         include API::Caching::CachedRepresenter
 
         self_link id_attribute: :id,
-                  title_getter: ->(*) { nil }
+                  title_getter: ->(*) {}
 
         property :gitlab_name, as: :login
         property :gitlab_email, as: :email

modules/gitlab_integration/lib/open_project/gitlab_integration/engine.rb

@@ -29,10 +29,10 @@
 
 require 'open_project/plugins'
 
-require_relative './patches/api/work_package_representer'
-require_relative './notification_handlers'
-require_relative './hook_handler'
-require_relative './services'
+require_relative 'patches/api/work_package_representer'
+require_relative 'notification_handlers'
+require_relative 'hook_handler'
+require_relative 'services'
 
 module OpenProject::GitlabIntegration
   class Engine < ::Rails::Engine
@@ -41,12 +41,12 @@ class Engine < ::Rails::Engine
     include OpenProject::Plugins::ActsAsOpEngine
 
     register 'openproject-gitlab_integration',
-             :author_url => 'https://github.com/btey/openproject',
+             author_url: 'https://github.com/btey/openproject',
              bundled: true do
       project_module(:gitlab, dependencies: :work_package_tracking) do
         permission(:show_gitlab_content,
-                  {},
-                  permissible_on: %i[work_package project])
+                   {},
+                   permissible_on: %i[work_package project])
       end
     end
 
@@ -74,7 +74,7 @@ class Engine < ::Rails::Engine
     end
 
     extend_api_response(:v3, :work_packages, :work_package,
-      &::OpenProject::GitlabIntegration::Patches::API::WorkPackageRepresenter.extension)
+                        &::OpenProject::GitlabIntegration::Patches::API::WorkPackageRepresenter.extension)
 
     add_api_path :gitlab_merge_requests_by_work_package do |id|
       "#{work_package(id)}/gitlab_merge_requests"
@@ -104,6 +104,5 @@ class Engine < ::Rails::Engine
       # Register the cron job to clean up old gitlab merge requests
       ::Cron::CronJob.register! ::Cron::ClearOldMergeRequestsJob
     end
-
   end
 end

modules/gitlab_integration/lib/open_project/gitlab_integration/hook_handler.rb

@@ -31,9 +31,9 @@ module OpenProject::GitlabIntegration
   class HookHandler
     # List of the gitlab events we can handle.
     KNOWN_EVENTS = %w[
-      push_hook 
-      issue_hook 
-      note_hook 
+      push_hook
+      issue_hook
+      note_hook
       merge_request_hook
       pipeline_hook
       system_hook
@@ -42,12 +42,12 @@ class HookHandler
     # A gitlab webhook happened.
     # We need to check validity of the data and send a Notification
     # which we process in our NotificationHandler.
-    def process(hook, request, params, user)
+    def process(_hook, request, params, user)
       event_type = request.env['HTTP_X_GITLAB_EVENT']
-      event_type.gsub!(' ','_')
+      event_type.tr!(' ', '_')
       event_type = event_type.to_s.downcase
 
-      Rails.logger.debug "Received gitlab webhook #{event_type}"
+      Rails.logger.debug { "Received gitlab webhook #{event_type}" }
 
       return 404 unless KNOWN_EVENTS.include?(event_type)
       return 403 unless user.present?
@@ -58,9 +58,9 @@ def process(hook, request, params, user)
                 .merge('open_project_user_id' => user.id,
                        'gitlab_event' => event_type)
 
-      OpenProject::Notifications.send("gitlab.#{event_type}", payload)
+      OpenProject::Notifications.send(:"gitlab.#{event_type}", payload)
 
-      return 200
+      200
     end
   end
 end

modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handler/issue_hook.rb

@@ -33,7 +33,7 @@ module NotificationHandler
     # Handles Gitlab issue notifications.
     class IssueHook
       include OpenProject::GitlabIntegration::NotificationHandler::Helper
-      
+
       def process(payload_params)
         @payload = wrap_payload(payload_params)
         user = User.find_by_id(payload.open_project_user_id)
@@ -58,14 +58,15 @@ def generate_notes(payload)
         }[payload.object_attributes.action]
 
         return nil unless accepted_actions.include? payload.object_attributes.action
+
         I18n.t("gitlab_integration.issue_#{key_action}_referenced_comment",
-          :issue_number => payload.object_attributes.iid,
-          :issue_title => payload.object_attributes.title,
-          :issue_url => payload.object_attributes.url,
-          :repository => payload.repository.name,
-          :repository_url => payload.repository.homepage,
-          :gitlab_user => payload.user.name,
-          :gitlab_user_url => payload.user.avatar_url)
+               issue_number: payload.object_attributes.iid,
+               issue_title: payload.object_attributes.title,
+               issue_url: payload.object_attributes.url,
+               repository: payload.repository.name,
+               repository_url: payload.repository.homepage,
+               gitlab_user: payload.user.name,
+               gitlab_user_url: payload.user.avatar_url)
       end
 
       def gitlab_issue
@@ -77,9 +78,10 @@ def gitlab_issue
 
       def upsert_issue(work_packages)
         return if work_packages.empty? && gitlab_issue.nil?
+
         OpenProject::GitlabIntegration::Services::UpsertIssue.new.call(payload,
-                                                                             work_packages: work_packages)
+                                                                       work_packages:)
       end
     end
   end
-end
+end

modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handler/merge_request_hook.rb

@@ -83,14 +83,14 @@ def generate_notes(payload)
 
         return nil unless key
 
-        I18n.t("gitlab_integration.merge_request_#{key_action ? key_action : key}_comment",
-               :mr_number => payload.object_attributes.iid,
-               :mr_title => payload.object_attributes.title,
-               :mr_url => payload.object_attributes.url,
-               :repository => payload.repository.name,
-               :repository_url => payload.repository.url,
-               :gitlab_user => payload.user.name,
-               :gitlab_user_url => payload.user.avatar_url)
+        I18n.t("gitlab_integration.merge_request_#{key_action || key}_comment",
+               mr_number: payload.object_attributes.iid,
+               mr_title: payload.object_attributes.title,
+               mr_url: payload.object_attributes.url,
+               repository: payload.repository.name,
+               repository_url: payload.repository.url,
+               gitlab_user: payload.user.name,
+               gitlab_user_url: payload.user.avatar_url)
       end
 
       def merge_request
@@ -102,10 +102,10 @@ def merge_request
 
       def upsert_merge_request(work_packages)
         return if work_packages.empty? && merge_request.nil?
+
         OpenProject::GitlabIntegration::Services::UpsertMergeRequest.new.call(payload,
-                                                                             work_packages: work_packages)
+                                                                              work_packages:)
       end
-
     end
   end
 end

modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handler/push_hook.rb

@@ -33,10 +33,11 @@ module NotificationHandler
     # Handles Gitlab commit notifications.
     class PushHook
       include OpenProject::GitlabIntegration::NotificationHandler::Helper
-      
+
       def process(payload_params)
         @payload = wrap_payload(payload_params)
         return nil unless payload.object_kind == 'push'
+
         payload.commits.each do |commit|
           user = User.find_by_id(payload.open_project_user_id)
           text = commit['title'] + " - " + commit['message']
@@ -53,15 +54,15 @@ def process(payload_params)
       def generate_notes(commit, payload)
         commit_id = commit['id']
         I18n.t("gitlab_integration.push_single_commit_comment",
-          :commit_number => commit_id[0, 8],
-          :commit_note => commit['message'],
-          :commit_url => commit['url'],
-          :commit_timestamp => commit['timestamp'],
-          :repository => payload.repository.name,
-          :repository_url => payload.repository.homepage,
-          :gitlab_user => payload.user_name,
-          :gitlab_user_url => payload.user_avatar)
+               commit_number: commit_id[0, 8],
+               commit_note: commit['message'],
+               commit_url: commit['url'],
+               commit_timestamp: commit['timestamp'],
+               repository: payload.repository.name,
+               repository_url: payload.repository.homepage,
+               gitlab_user: payload.user_name,
+               gitlab_user_url: payload.user_avatar)
       end
     end
   end
-end
+end

modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handler/system_hook.rb

@@ -33,10 +33,11 @@ module NotificationHandler
     # Handles Gitlab commit notifications.
     class SystemHook
       include OpenProject::GitlabIntegration::NotificationHandler::Helper
-      
+
       def process(payload_params)
         @payload = wrap_payload(payload_params)
         return nil unless payload.object_kind == 'push'
+
         payload.commits.each do |commit|
           user = User.find_by_id(payload.open_project_user_id)
           text = commit['title'] + " - " + commit['message']
@@ -53,14 +54,14 @@ def process(payload_params)
       def generate_notes(commit, payload)
         commit_id = commit['id']
         I18n.t("gitlab_integration.push_single_commit_comment",
-          :commit_number => commit_id[0, 8],
-          :commit_note => commit['message'],
-          :commit_url => commit['url'],
-          :commit_timestamp => commit['timestamp'],
-          :repository => payload.repository.name,
-          :repository_url => payload.repository.homepage,
-          :gitlab_user => payload.user_name,
-          :gitlab_user_url => payload.user_avatar)
+               commit_number: commit_id[0, 8],
+               commit_note: commit['message'],
+               commit_url: commit['url'],
+               commit_timestamp: commit['timestamp'],
+               repository: payload.repository.name,
+               repository_url: payload.repository.homepage,
+               gitlab_user: payload.user_name,
+               gitlab_user_url: payload.user_avatar)
       end
     end
   end