chore[Op#57579]: ensure subheader component is appropriately hidden

opf · Sep 6, 2024 · a79e03a · a79e03a
1 parent 7344b21
commit a79e03a
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/app/views/admin/custom_fields/custom_field_projects/index.html.erb b/app/views/admin/custom_fields/custom_field_projects/index.html.erb
@@ -35,7 +35,7 @@ See COPYRIGHT and LICENSE files for more details.
 %>
 
 <%=
-  render(Primer::OpenProject::SubHeader.new) do |component|
+  render(Primer::OpenProject::SubHeader.new(test_selector: "add-projects-sub-header")) do |component|
     component.with_action_component do
       render(Primer::Beta::Button.new(
         scheme: :primary,
@@ -47,7 +47,7 @@ See COPYRIGHT and LICENSE files for more details.
         I18n.t(:label_add_projects)
       end
     end
-  end unless @custom_field.required?
+  end unless @custom_field.is_for_all?
 %>
 
 <%=

diff --git a/app/views/admin/settings/project_custom_fields/project_mappings.html.erb b/app/views/admin/settings/project_custom_fields/project_mappings.html.erb
@@ -35,7 +35,7 @@ See COPYRIGHT and LICENSE files for more details.
 %>
 
 <%=
-  render(Primer::OpenProject::SubHeader.new) do |component|
+  render(Primer::OpenProject::SubHeader.new(test_selector: "add-projects-sub-header")) do |component|
     component.with_action_component do
       render(Primer::Beta::Button.new(
         scheme: :primary,

diff --git a/spec/features/admin/custom_fields/custom_fields_project_spec.rb b/spec/features/admin/custom_fields/custom_fields_project_spec.rb
@@ -130,6 +130,7 @@
 
       it "renders a blank slate" do
         expect(page).to have_text("For all projects")
+        expect(page).not_to have_test_selector("add-projects-sub-header")
       end
     end
   end

diff --git a/spec/features/admin/project_custom_fields/project_mappings_spec.rb b/spec/features/admin/project_custom_fields/project_mappings_spec.rb
@@ -159,6 +159,7 @@
 
       it "renders a blank slate" do
         expect(page).to have_text("Required in all projects")
+        expect(page).not_to have_test_selector("add-projects-sub-header")
       end
     end
   end
-Original file line number
+Diff line change
@@ Expand Up / @@ -130,6 +130,7 @@ @@
           it "renders a blank slate" do
             expect(page).to have_text("For all projects")
+            expect(page).not_to have_test_selector("add-projects-sub-header")
           end
         end
       end
@@ Expand Down @@