Skip to content

Commit

Permalink
[#55801] Review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
judithroth committed Jun 26, 2024
1 parent 9670967 commit a873e1d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,12 @@ def initialize(project_mapping:, project_custom_field:, **)
def render?
!@project_custom_field.required?
end

private

def title
I18n.t("projects.settings.project_custom_fields.new_project_mapping_form.add_projects")
end
end
end
end
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ See COPYRIGHT and LICENSE files for more details.
) do |form|
concat(render(Primer::Alpha::Dialog::Body.new(
id: DIALOG_BODY_ID, test_selector: DIALOG_BODY_ID, aria: { label: title },
classes: "FormControl-horizontalGroup--sm-vertical",
style: "min-height: 300px"
)) do
render(Projects::CustomFields::CustomFieldMappingForm.new(form, project_mapping: @project_mapping))
Expand Down

0 comments on commit a873e1d

Please sign in to comment.