Skip to content

Commit

Permalink
fix[Op#51022]: Do not split translations for I18n benefits
Browse files Browse the repository at this point in the history
Co-authored-by: Henriette Darge <[email protected]>
  • Loading branch information
akabiru and HDinger committed Nov 29, 2023
1 parent 47de181 commit ae97545
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,8 @@
<% header.with_description(test_selector: 'storage-new-page-header--description') do %>
<%=
t("storages.instructions.new_storage",
file_storage_docs_link: render(
Primer::Beta::Link.new(href: ::OpenProject::Static::Links[:storage_docs][:"#{@storage.short_provider_type}_setup"][:href], target: '_blank')
) { t("storages.instructions.file_storage_docs_link", provider_name: I18n.t("storages.provider_types.#{@storage.short_provider_type}.name")).html_safe }
provider_link: ::OpenProject::Static::Links[:storage_docs][:"#{@storage.short_provider_type}_setup"][:href],

Check notice

Code scanning / Brakeman

Unescaped model attribute. Note

Unescaped model attribute.
provider_name: I18n.t("storages.provider_types.#{@storage.short_provider_type}.name")
).html_safe
%>
<% end %>
Expand Down
3 changes: 1 addition & 2 deletions modules/storages/config/locales/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,7 @@ en:
managed_project_folders_application_password: >
Copy this value from:
managed_project_folders_application_password_caption: "Enable automatic managed folders by copying this value from: %{provider_type_link}."
new_storage: "Read our documentation on %{file_storage_docs_link} integration for more information."
file_storage_docs_link: "setting up a %{provider_name} file storage"
new_storage: "Read our documentation on <a target='_blank' href='%{provider_link}'>setting up a %{provider_name} file storage</a> integration for more information."
no_storage_set_up: "There are no file storages set up yet."
no_specific_folder: "By default, each user will start at their own home folder when they upload a file."
automatic_folder: "This will automatically create a root folder for this project and manage the access permissions for each project member."
Expand Down

0 comments on commit ae97545

Please sign in to comment.