[#58737] fix flaky watcher tab spec (#17162)

* [#58737] fix flaky watcher tab spec

* fix typo

spec/features/work_packages/tabs/watcher_tab_spec.rb

@@ -8,14 +8,18 @@
   let(:work_package) { create(:work_package, project:) }
   let(:tabs) { Components::WorkPackages::Tabs.new(work_package) }
   let(:role) { create(:project_role, permissions:) }
-  let(:user) { create(:user, member_with_roles: { project => role }) }
   let(:permissions) do
     %i(view_work_packages
        view_work_package_watchers
        delete_work_package_watchers
        add_work_package_watchers)
   end
 
+  # Ensure users are eagerly created (and at top level). #58737 was caused by `other_user` not being there
+  # in time for some cases => flaky user auto completer specs
+  let!(:user) { create(:user, member_with_roles: { project => role }) }
+  let!(:other_user) { create(:user, firstname: "Other", member_with_roles: { project => role }) }
+
   let(:watch_button) { find_by_id "watch-button" }
   let(:watchers_tab) { find(".op-tab-row--link_selected", text: "WATCHERS") }
 
@@ -113,9 +117,7 @@ def expect_button_is_not_watching
       it_behaves_like "watch and unwatch with button"
     end
 
-    context "when auto completing users", skip: "Flaky test, see #58737" do
-      let!(:other_user) { create(:user, firstname: "Other", member_with_roles: { project => role }) }
-
+    context "when auto completing users" do
       it "shows only the email address of the current user by default" do
         autocomplete = find(".wp-watcher--autocomplete ng-select")
         target_dropdown = search_autocomplete autocomplete,