Merge pull request #17351 from top4ek/patch-3

Fix BCF issue associated filter name
opf · Dec 12, 2024 · cbc6332 · cbc6332
2 parents 342b0e3 + f9fd909
commit cbc6332
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/modules/bim/app/models/bim/queries/work_packages/filter/bcf_issue_associated_filter.rb b/modules/bim/app/models/bim/queries/work_packages/filter/bcf_issue_associated_filter.rb
@@ -41,6 +41,10 @@ def allowed_values
       ]
     end
 
+    def human_name
+      I18n.t("bcf.label_bcf_issue_associated")
+    end
+
     def where
       if associated?
         ::Queries::Operators::All.sql_for_field(values, ::Bim::Bcf::Issue.table_name, "id")

diff --git a/modules/bim/config/locales/en.yml b/modules/bim/config/locales/en.yml
@@ -11,6 +11,7 @@ en:
     label_bcf: 'BCF'
     label_imported_failed: 'Failed imports of BCF topics'
     label_imported_successfully: 'Successfully imported BCF topics'
+    label_bcf_issue_associated: "BCF issue associated"
     issues: "Issues"
     recommended: 'recommended'
     not_recommended: 'not recommended'

diff --git a/modules/bim/spec/models/queries/work_packages/filter/bcf_issue_associated_filter_spec.rb b/modules/bim/spec/models/queries/work_packages/filter/bcf_issue_associated_filter_spec.rb
@@ -35,6 +35,7 @@
     let(:model) { WorkPackage }
     let(:class_key) { :bcf_issue_associated }
     let(:type) { :list }
+    let(:human_name) { "BCF issue associated" }
 
     describe "#available?" do
       context "if bim is enabled", with_config: { edition: "bim" } do