Allow deletion of users that favored projects

https://community.openproject.org/work_packages/60171

app/workers/principals/delete_job.rb

@@ -66,6 +66,7 @@ def delete_associated(principal)
     delete_notifications(principal)
     delete_private_queries(principal)
     delete_tokens(principal)
+    delete_favorites(principal)
   end
 
   def delete_notifications(principal)
@@ -77,6 +78,10 @@ def delete_private_queries(principal)
     CostQuery.where(user_id: principal.id, is_public: false).delete_all
   end
 
+  def delete_favorites(principal)
+    Favorite.where(user_id: principal.id).delete_all
+  end
+
   def delete_tokens(principal)
     ::Token::Base.where(user_id: principal.id).destroy_all
   end

spec/workers/principals/delete_job_integration_spec.rb

@@ -475,6 +475,17 @@
       it_behaves_like "cost_query handling"
       it_behaves_like "project query handling"
       it_behaves_like "mention rewriting"
+
+      describe "favorites" do
+        before do
+          project.add_favoring_user(principal)
+          job
+        end
+
+        it "removes the assigned_to association to the principal" do
+          expect(project.favoring_users.reload).to be_empty
+        end
+      end
     end
 
     context "with a group" do