[#52147] fix cop errors

opf · Oct 14, 2024 · e2550a5 · e2550a5
1 parent 302770f
commit e2550a5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/app/helpers/sort_helper.rb b/app/helpers/sort_helper.rb
@@ -77,7 +77,9 @@
 # - Introduces instance variables: @sort_default, @sort_criteria
 # - Introduces param :sort
 #
-
+# rubocop:disable Lint/RedundantCopDisableDirective, Rails/HelperInstanceVariable
+# TODO: We should not use instance variables in our rails helpers. Since this is a bigger piece of work, for now
+# we just disable the respective cop. Due to a bug, we must also disable the redundancy cop.
 module SortHelper
   class SortCriteria
     attr_reader :criteria
@@ -554,3 +556,4 @@ def get_caption(column, options)
     caption
   end
 end
+# rubocop:enable Rails/HelperInstanceVariable, Lint/RedundantCopDisableDirective
diff --git a/frontend/src/stimulus/controllers/dynamic/table-action-menu.controller.ts b/frontend/src/stimulus/controllers/dynamic/table-action-menu.controller.ts
@@ -47,9 +47,9 @@ export default class TableActionMenuController extends Controller {
     }
   }
 
-  filterBy(event: Event) {
+  filterBy(event:Event) {
     // Sometimes the filterController was not loaded during `connect`, so we try again here:
-    if (!this.filterController) { this.findFilterController() }
+    if (!this.filterController) { this.findFilterController(); }
 
     const button = event.currentTarget as HTMLElement;