Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#43009] Module gitlab_integration added #13240

Closed
wants to merge 3 commits into from
Closed

[#43009] Module gitlab_integration added #13240

wants to merge 3 commits into from

Conversation

foxweb
Copy link
Contributor

@foxweb foxweb commented Jul 25, 2023

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 25, 2023
View reviewed changes
modules/gitlab_integration/frontend/module/git-actions/git-actions.service.ts Dismissed
}

private sanitizeShellInput(str:string):string {
return `${str.replace(/'/g, '\\\'')}`;

Check failure

Code scanning / CodeQL

Incomplete string escaping or encoding High

This does not escape backslash characters in the input.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to rewrite this :(

@oliverguenther
Copy link
Member

Hi @foxweb , the plugin appears to have no specs. We will not be able to include this into the core without adequate testing similar to the github integration (plus any extensions made for gitlab).

@klaustopher
Copy link
Contributor

Closing in favor of #14881

@klaustopher klaustopher closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
contribution
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@foxweb @oliverguenther @klaustopher