Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#49977] PDF export (single work package): Include all attributes and fields according to the work package type form configuration #13735

Conversation

as-op
Copy link
Contributor

@as-op as-op commented Sep 20, 2023

For a single work package PDF Export this PR:

  • displays attributes and custom fields according to the work package type form configuration in the attributes table
  • refactors method for wp form type spent_units into format exporter
  • adds format exporter for derived_remaining_hours
  • splits wp form type date into start_date due_date duration

https://community.openproject.org/work_packages/49977

as-op and others added 3 commits September 20, 2023 16:03
…include-all-attributes-and-fields-according-to-the-work-package-type-form-configuration
…include-all-attributes-and-fields-according-to-the-work-package-type-form-configuration
@as-op as-op marked this pull request as ready for review September 21, 2023 09:01
Copy link
Contributor

@HDinger HDinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @as-op

I did not have a look at the code as that is not my field of expertise but just tested it. I noticed two things:

  • All custom fields are shown with their ID instead of their name. (see green marks in the picture)
  • For Custom Fields of type "long text", the value is shown as raw text in the table, and then again compiled below the table. Is that intended? (see blue marks in the picture)
Bildschirmfoto 2023-09-28 um 08 09 50

@as-op
Copy link
Contributor Author

as-op commented Sep 28, 2023

Thanks a lot, @HDinger ! Both issues are not intended and are indeed bugs. I'll fix those.

as-op and others added 7 commits September 28, 2023 12:13
…work-package-include-all-attributes-and-fields-according-to-the-work-package-type-form-configuration' into feature/49977-pdf-export-single-work-package-include-all-attributes-and-fields-according-to-the-work-package-type-form-configuration
…include-all-attributes-and-fields-according-to-the-work-package-type-form-configuration
…include-all-attributes-and-fields-according-to-the-work-package-type-form-configuration
…rt-single-work-package-include-all-attributes-and-fields-according-to-the-work-package-type-form-configuration
@as-op as-op removed the needs review label Nov 6, 2023
@as-op as-op merged commit 808cb5b into dev Nov 6, 2023
13 checks passed
@as-op as-op deleted the feature/49977-pdf-export-single-work-package-include-all-attributes-and-fields-according-to-the-work-package-type-form-configuration branch November 6, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants