Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid assigning inactive time entry activity #14041

Merged

Conversation

oliverguenther
Copy link
Member

@oliverguenther oliverguenther commented Oct 27, 2023

When assigning a default TimeEntryActivity, the project needs to be present (if at all provided by attributes) so that we can ensure to only assign an active activity. Otherwise, the TimeEntry becomes invalid and unable to create.

https://community.openproject.org/work_packages/50784

@oliverguenther oliverguenther force-pushed the fix/50784/time-tracking-breaks-with-inactive-activity branch from ad423d8 to 53841a9 Compare October 30, 2023 13:30
Copy link
Contributor

@dombesz dombesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👏

@oliverguenther oliverguenther merged commit 14f8721 into dev Nov 2, 2023
10 checks passed
@oliverguenther oliverguenther deleted the fix/50784/time-tracking-breaks-with-inactive-activity branch November 2, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants