[50254] Filtering on share modal #14075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HDinger
force-pushed
the
implementation/50254-filtering-on-share-modal
branch
2 times, most recently
from
b9aa7b5 to
6cfad47
Compare
HDinger
force-pushed
the
implementation/50254-filtering-on-share-modal
branch
from
8defbc1 to
a3dcb67
Compare
…ut any additional js required
HDinger
force-pushed
the
implementation/50254-filtering-on-share-modal
branch
from
a5b393d to
8a1b4af
Compare
HDinger
force-pushed
the
implementation/50254-filtering-on-share-modal
branch
from
8a1b4af to
96c118f
Compare
|
I added the still open points to the description. Futher, the code needs some cleanup, especially this part. Other than that this ready for a first review. |
app/components/work_packages/share/bulk_permission_button_component.html.erb
Show resolved
Hide resolved
frontend/src/stimulus/controllers/dynamic/work-packages/share/bulk-selection.controller.ts
Show resolved
Hide resolved
…other way around). Further, the test has been adapted to it.
|
I excluded the inheritance problem to #50939 as I am unsure about the expected results and would like to discuss that with product first. |
The `MemberQuery` has a default_scope that checks a non-admin has a certain set of permissions which are not required for the behavior of the share modal (or visibility of work package shares for that matter). Given that visibility is unscoped for the share modal, extracting a separate query class that inherits from the MemberQuery sans the default_scope made sense as a way to keep these two in sync minus the varying visibility levels based on the current_user.
There were a couple of specs failing due to the new query layer and injectable shares into the ModalBodyComponent. This commit standardizes the interface to prevent this in an easy to follow manner.
Thanks for extracting Attila!
aaron-contreras
approved these changes
Nov 13, 2023
|
Thanks a lot, @aaron-contreras for jumping in! 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open Questions
Handled separatly
When the filter results are empty, the Box switches to the blankslate, where no filter is available. Thus I cannot leave this stage any more.See ticketInherited permissions are in filter result set but might show a different permission if the user was shared separatlySee tickethttps://community.openproject.org/projects/openproject/work_packages/50254/activity