-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/50677 users that are shared with a wp cannot be added as project members any more #14102
Merged
ulferts
merged 6 commits into
release/13.1
from
bug/50677-users-that-are-shared-with-a-wp-cannot-be-added-as-project-members-any-more
Dec 6, 2023
Merged
Bug/50677 users that are shared with a wp cannot be added as project members any more #14102
ulferts
merged 6 commits into
release/13.1
from
bug/50677-users-that-are-shared-with-a-wp-cannot-be-added-as-project-members-any-more
Dec 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way, they no longer show up on the administration page of user`s projects
ulferts
force-pushed
the
bug/50677-users-that-are-shared-with-a-wp-cannot-be-added-as-project-members-any-more
branch
from
November 6, 2023 16:12
2d8e7f1
to
9ae40a3
Compare
klaustopher
approved these changes
Nov 7, 2023
Would it maybe make sense that we add scopes on memberships? scope :on_project, -> { where(entity: nil).where.not(project_id: nil) }
scope :global, -> { where(entity: nil).where(project_id: nil) }
scope :on_entity, -> { where.not(entity: nil, project_id: nil) } Then we could use those instead of spreading |
ulferts
force-pushed
the
bug/50677-users-that-are-shared-with-a-wp-cannot-be-added-as-project-members-any-more
branch
3 times, most recently
from
November 20, 2023 17:14
a0295a7
to
fadb78e
Compare
ulferts
force-pushed
the
bug/50677-users-that-are-shared-with-a-wp-cannot-be-added-as-project-members-any-more
branch
from
November 20, 2023 17:40
fadb78e
to
84995ea
Compare
…re-shared-with-a-wp-cannot-be-added-as-project-members-any-more
ulferts
force-pushed
the
bug/50677-users-that-are-shared-with-a-wp-cannot-be-added-as-project-members-any-more
branch
from
December 4, 2023 15:04
3006c67
to
e22618a
Compare
@klaustopher all the scopes should now be in as discussed. |
klaustopher
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
ulferts
deleted the
bug/50677-users-that-are-shared-with-a-wp-cannot-be-added-as-project-members-any-more
branch
December 6, 2023 08:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
Member
s on entities like WorkPackages from two scopes and by that:https://community.openproject.org/wp/50677