-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix historic attributes query #14188
Closed
klaustopher
wants to merge
77
commits into
work-package-permission-fixes
from
fix-historic-attributes
Closed
Fix historic attributes query #14188
klaustopher
wants to merge
77
commits into
work-package-permission-fixes
from
fix-historic-attributes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://community.openproject.org/work_packages/51010 Also, adds the count to the meeting tab as a sideeffect
…ft-instead-of-being-on-the-right-of-the-custom-fields-page-in-project-settings [15285] Custom field button moved left (instead of being on the right) of the Custom fields page in Project settings
… limit has been reached already when opening the modal
…ers page and the share modal
…e members page and the share modal
Bumps [eslint](https://github.com/eslint/eslint) from 8.53.0 to 8.54.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.53.0...v8.54.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
fix(docs): use lowercase filename
Fix/bump gems
Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.33.2 to 3.33.3. - [Release notes](https://github.com/zloirock/core-js/releases) - [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/zloirock/core-js/commits/v3.33.3/packages/core-js) --- updated-dependencies: - dependency-name: core-js dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
This reverts commit 2d32809.
Add optimistic locking to meetings and agenda items
Show meeting tab when user has view_meetings anywhere
This was specified to already be the case according to the documentation but was never implemented
Bumps [codemirror](https://github.com/codemirror/basic-setup) from 5.65.15 to 5.65.16. - [Changelog](https://github.com/codemirror/basic-setup/blob/main/CHANGELOG.md) - [Commits](https://github.com/codemirror/basic-setup/commits) --- updated-dependencies: - dependency-name: codemirror dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…irect-to-project-foler-with-waiting-under-projectsproject_idproject_storagesidopen [#50437] Rename ensure_access to ensure_connection.
…#14186) * [OP-50740] Set width of primer form inputs to :large in storage forms * [OP-50740]: set input widths for the oauth client form * [OP-50740]: change the provider type select input width to small * [OP-50740]: update the version in the overrides section as well --------- Co-authored-by: Kabiru Mwenja <[email protected]>
klaustopher
force-pushed
the
fix-historic-attributes
branch
from
November 21, 2023 11:52
e606923
to
3b3da05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The historic attributes query needs to modify the
WHERE
conditions as well now. Previously everything was fixed because we simplyJOIN
ed the permission related stuff. Now we have theUNION
query that selects allowed_to for projects and work packages. So we need to build a new AST Walker, that also modifies all the other conditions wherework_packages
table is joined and move it tojournalized_work_packages
.