Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix embedding of macros #14195

Merged
merged 5 commits into from
Nov 21, 2023
Merged

Fix embedding of macros #14195

merged 5 commits into from
Nov 21, 2023

Conversation

oliverguenther
Copy link
Member

Replaces dynamic bootstrapped components with custom elements

  • attribute macros
  • embedded table macro
  • work package quickinfo

https://community.openproject.org/work_packages/51147

@oliverguenther oliverguenther force-pushed the fix/meeting-agenda-item-macros branch from ce993b0 to a3899b5 Compare November 21, 2023 08:30
@oliverguenther oliverguenther force-pushed the fix/meeting-agenda-item-macros branch from a3899b5 to d1e5589 Compare November 21, 2023 09:15
HDinger
HDinger reviewed Nov 21, 2023
View reviewed changes
Copy link
Contributor

@HDinger HDinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm. 👍
The WP create button looks however still really broken. I am aware that this was not part of this PR, but it might be worth to do it in the same run.

Bildschirmfoto 2023-11-21 um 12 18 25

@oliverguenther oliverguenther merged commit 6066001 into dev Nov 21, 2023
10 of 11 checks passed
@oliverguenther oliverguenther deleted the fix/meeting-agenda-item-macros branch November 21, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HDinger HDinger HDinger left review comments

Assignees
No one assigned
Labels
bugfix needs review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverguenther @HDinger