Fix historic attributes #14199
Merged
Fix historic attributes #14199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Errors come from the underlying PR that is hiding those errors because the failing unit tests here prevent the feature tests. I'll merge this into the other branch to fix everything in there. |
klaustopher
merged commit cc15f36
into
work-package-permission-fixes
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The historic attributes query needs to modify the
WHEREconditions as well now. Previously everything was fixed because we simplyJOINed the permission related stuff. Now we have theUNIONquery that selects allowed_to for projects and work packages. So we need to build a new AST Walker, that also modifies all the other conditions wherework_packagestable is joined and move it tojournalized_work_packages.