-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#50908] Implement redirect to project folder with waiting under /projects/:project_id/project_storages/:id/open #14204
Merged
ba1ash
merged 11 commits into
dev
from
implementation/50908-implement-redirect-to-project-foler-with-waiting-under-projectsproject_idproject_storagesidopen
Nov 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jects/:project_id/project_storages/:id/open https://community.openproject.org/work_packages/50908
Subscribe to close/cancel events produced by ModalDialogElement to stop polling.
…oject-foler-with-waiting-under-projectsproject_idproject_storagesidopen
apfohl
suggested changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No major things to change. Mostly one 🟡 I would like you to change. The other 🟡 and 🟢 are just topics I would like to talk about with someone.
modules/storages/app/controllers/storages/project_storages_controller.rb
Outdated
Show resolved
Hide resolved
modules/storages/app/controllers/storages/project_storages_controller.rb
Outdated
Show resolved
Hide resolved
modules/storages/app/controllers/storages/project_storages_controller.rb
Outdated
Show resolved
Hide resolved
modules/storages/lib/api/v3/project_storages/project_storage_open_api.rb
Show resolved
Hide resolved
Refactor project_storages_controller to be more readable. Extract some blocks of code to named methods.
…mplement-redirect-to-project-foler-with-waiting-under-projectsproject_idproject_storagesidopen
…oject-foler-with-waiting-under-projectsproject_idproject_storagesidopen
apfohl
approved these changes
Nov 30, 2023
ba1ash
deleted the
implementation/50908-implement-redirect-to-project-foler-with-waiting-under-projectsproject_idproject_storagesidopen
branch
November 30, 2023 12:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See feature for description: https://community.openproject.org/wp/50437
Link to the implementation chunk(no useful information there): https://community.openproject.org/work_packages/50908
Some technical implementation details worth mentioning:
type
is a class name for desired modal view_component.parameter
are attributes that are passed to the modal class constructor.storages/open-project-storage-modal.controller.ts
.In short:
storages/project_storages_controller.rb
. Check the test for it:modules/storages/spec/requests/project_storages_open_spec.rb
. I believe I was quite descriptive there.