Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[50881] Starting Guided Tour (from the Scrum project) does not work for non-admin #14250

Conversation

bsatarnejad
Copy link
Contributor

@bsatarnejad bsatarnejad commented Nov 27, 2023

  • The link should be removed from the overview section of the scrum project.
  • The whole code for the scrum tour can be removed as well.

https://community.openproject.org/work_packages/50881/activity

@bsatarnejad bsatarnejad force-pushed the 50881-starting-guided-Tour-from-the-Scrum-project-does-not-work-for-non-admin branch from 8bd59ec to 394d948 Compare November 28, 2023 13:13
@bsatarnejad bsatarnejad marked this pull request as ready for review November 28, 2023 13:59
@bsatarnejad bsatarnejad requested a review from a team November 28, 2023 14:01
Copy link
Contributor

@HDinger HDinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works perfectly fne for freshly seeded instances. I am wondering however, whether we want to catch existing ones as well and remove the text via a migration. What do you think?

@HDinger
Copy link
Contributor

HDinger commented Nov 29, 2023

That works perfectly fne for freshly seeded instances. I am wondering however, whether we want to catch existing ones as well and remove the text via a migration. What do you think?

I discussed that with the product team and we agreed to accept that, as it only affects a very small number of old instances. I will update the ticket accordingly.

@HDinger HDinger merged commit 6cff3ce into dev Nov 29, 2023
11 checks passed
@HDinger HDinger deleted the 50881-starting-guided-Tour-from-the-Scrum-project-does-not-work-for-non-admin branch November 29, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants