Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Refactor nextcloud files query spec to vcr #14265

Merged
merged 2 commits into from
Nov 30, 2023
Merged

[chore] Refactor nextcloud files query spec to vcr #14265

merged 2 commits into from
Nov 30, 2023

Conversation

Kharonus
Copy link
Member

WAT?

  • refactored files query spec for nextcloud query to use VCR cassettes
  • some small adjustments of production code to satisfy common interface
    • root entity has now name Root in both queries, and no longer / in nextcloud
    • error data contains now source in payload for files query of nextcloud

But ... WHY?

  • because VCR is the much more awesome test setup

@Kharonus Kharonus requested a review from akabiru November 28, 2023 14:57
@Kharonus Kharonus self-assigned this Nov 28, 2023
akabiru
akabiru reviewed Nov 28, 2023
View reviewed changes
Copy link
Member

@akabiru akabiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 🥇 Seems there're failing specs- good to merge from POV on green 👍🏾

@Kharonus
Copy link
Member Author

Yeah, specs were red, because I recorded the cassettes with my local nextcloud on nextcloud-sub.local/html which caused the cassette matching to fail.

I rerecorded them now with a nextcloud.local instance.

akabiru
akabiru approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@akabiru akabiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Kharonus Kharonus merged commit 3a6df28 into dev Nov 30, 2023
9 checks passed
@Kharonus Kharonus deleted the chore/refactor-nextcloud-files-query-spec-to-vcr branch November 30, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akabiru akabiru akabiru approved these changes

Assignees

@Kharonus Kharonus

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kharonus @akabiru