Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#51275] Fix Primer checkboxes lacking a background in High Contrast Mode #14267

Merged
merged 2 commits into from
Nov 29, 2023

Fix: Override primer variable with custom OP colors on normal light mode

755c326
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

[#51275] Fix Primer checkboxes lacking a background in High Contrast Mode #14267

Fix: Override primer variable with custom OP colors on normal light mode
755c326
Select commit
Loading
Failed to load commit list.
GitHub Actions / eslint succeeded Nov 29, 2023 in 1s

reviewdog [eslint] report

reported by reviewdog 🐶

Findings (0)
Filtered Findings (5824)

frontend/src/app/app.module.ts|266 col 3| Lifecycle interface 'DoBootstrap' should be implemented for method 'ngDoBootstrap'. (https://angular.io/styleguide#style-09-01)
frontend/src/app/app.module.ts|278 col 11| Unsafe assignment of an any value.
frontend/src/app/app.module.ts|278 col 25| Unsafe member access .injector on an any value.
frontend/src/app/app.module.ts|278 col 25| Unsafe call of an any typed value.
frontend/src/app/app.module.ts|278 col 25| Unexpected dangling '' in 'injector'.
frontend/src/app/app.module.ts|278 col 36| Unexpected any. Specify a different type.
frontend/src/app/app.module.ts|279 col 5| Unsafe member access .forEach on an any value.
frontend/src/app/app.module.ts|279 col 5| Unsafe call of an any typed value.
frontend/src/app/app.module.ts|279 col 5| Unsafe member access .call on an any value.
frontend/src/app/app.module.ts|279 col 5| Unsafe call of an any typed value.
frontend/src/app/app.module.ts|281 col 48| Unexpected any. Specify a different type.
frontend/src/app/core/apiv3/api-v3.service.spec.ts|54 col 32| Unexpected any. Specify a different type.
frontend/src/app/core/apiv3/api-v3.service.spec.ts|55 col 32| Unsafe argument of type any assigned to a parameter of type string | string[][] | Record<string, string> | URLSearchParams | undefined.
frontend/src/app/core/apiv3/api-v3.service.spec.ts|83 col 7| No new line before expect
frontend/src/app/core/apiv3/cache/cachable-apiv3-collection.ts|65 col 24| Unsafe argument of type any assigned to a parameter of type T.
frontend/src/app/core/apiv3/cache/cachable-apiv3-collection.ts|65 col 36| Unexpected any. Specify a different type.
frontend/src/app/core/apiv3/cache/cachable-apiv3-collection.ts|76 col 5| Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the void operator.
frontend/src/app/core/apiv3/cache/cachable-apiv3-resource.ts|133 col 5| Unsafe return of an any typed value.
frontend/src/app/core/apiv3/cache/cachable-apiv3-resource.ts|138 col 15| Unsafe member access .schema on an any value.
frontend/src/app/core/apiv3/cache/cachable-apiv3-resource.ts|140 col 33| Unsafe argument of type any assigned to a parameter of type string.
frontend/src/app/core/apiv3/cache/cachable-apiv3-resource.ts|140 col 33| Unsafe member access .schema on an any value.
frontend/src/app/core/apiv3/cache/cachable-apiv3-resource.ts|148 col 12| Unexpected any. Specify a different type.
frontend/src/app/core/apiv3/cache/cachable-apiv3-resource.ts|155 col 5| Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the void operator.
frontend/src/app/core/apiv3/cache/state-cache.service.ts|36 col 3| 'forkJoin' is defined but never used. Allowed unused vars must match /^/u.
frontend/src/app/core/apiv3/cache/state-cache.service.ts|36 col 3| 'forkJoin' is defined but never used. Allowed unused vars must match /^/u.
frontend/src/app/core/apiv3/cache/state-cache.service.ts|116 col 29| Forbidden non-null assertion.
frontend/src/app/core/apiv3/cache/state-cache.service.ts|116 col 43| Unsafe argument of type any assigned to a parameter of type T.
frontend/src/app/core/apiv3/cache/state-cache.service.ts|116 col 55| Unexpected any. Specify a different type.
frontend/src/app/core/apiv3/endpoints/backups/apiv3-backups-path.ts|36 col 14| Expected newline after '('.
frontend/src/app/core/apiv3/endpoints/backups/apiv3-backups-path.ts|37 col 29| Expected newline before ')'.
frontend/src/app/core/apiv3/endpoints/capabilities/apiv3-capabilities-paths.ts|36 col 14| Expected newline after '('.
frontend/src/app/core/apiv3/endpoints/capabilities/apiv3-capabilities-paths.ts|37 col 30| Expected newline before ')'.
frontend/src/app/core/apiv3/endpoints/configuration/apiv3-configuration-path.ts|38 col 14| Expected newline after '('.
frontend/src/app/core/apiv3/endpoints/configuration/apiv3-configuration-path.ts|39 col 29| Expected newline before ')'.
frontend/src/app/core/apiv3/endpoints/configuration/apiv3-configuration-path.ts|48 col 5| Return statement should not contain assignment.
frontend/src/app/core/apiv3/endpoints/days/api-v3-days-paths.ts|33 col 3| 'ApiV3GettableResource' is defined but never used. Allowed unused vars must match /^/u.
frontend/src/app/core/apiv3/endpoints/days/api-v3-days-paths.ts|33 col 3| 'ApiV3GettableResource' is defined but never used. Allowed unused vars must match /^_/u.
frontend/src/app/core/apiv3/endpoints/days/api-v3-days-paths.ts|41 col 14| Expected newline after '('.
frontend/src/app/core/apiv3/endpoints/days/api-v3-days-paths.ts|42 col 30| Expected newline before ')'.
frontend/src/app/core/apiv3/endpoints/grids/apiv3-grid-form.ts|43 col 53| Don't use Object as a type. The Object type actually means "any non-nullish value", so it is marginally better than unknown.

View more details on GitHub Actions