Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#51275] Fix Primer checkboxes lacking a background in High Contrast Mode #14267

Merged
merged 2 commits into from
Nov 29, 2023
Merged

[#51275] Fix Primer checkboxes lacking a background in High Contrast Mode #14267

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e7c30f
Fix: Remove mapping of Primer's CSS variable with our variable
aaron-contreras Nov 28, 2023
755c326
Fix: Override primer variable with custom OP colors on normal light mode
aaron-contreras Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/views/custom_styles/_primer_color_mapping.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@
[data-color-mode] {
--body-background: var(--color-canvas-default);
--body-font-color: var(--color-fg-default);
--color-accent-fg: var(--content-link-color) !important;
}
/* Override Primer variable to ensure compatibility with currently
configured design outside of high contrast mode */
[data-color-mode]:not([data-light-theme=light_high_contrast]) {
--color-accent-fg: var(--content-link-color) !important;
}
[data-light-theme=light_high_contrast]{
--avatar-border-color: var(--color-avatar-border);
Expand Down
Loading